Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 1867383002: Revert of Fix printf formats (Closed)

Created:
4 years, 8 months ago by JF
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix printf formats (patchset #8 id:140001 of https://codereview.chromium.org/1869433004/ ) Reason for revert: One small issue easily fixed here: https://codereview.chromium.org/1867333003/ But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful: Stderr: f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect format specifier", 0) It's easier to revert for now, I'll dig more into the docs: https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx And then resubmit, making sure I run these bots. Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d > Cr-Commit-Position: refs/heads/master@{#35365} TBR=jochen@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4c4fdc2d63cc20cf66d3ef06d42187c230ec0081 Cr-Commit-Position: refs/heads/master@{#35366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -339 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/simulator-arm64.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/ast/prettyprinter.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/ast/prettyprinter.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/base/compiler-specific.h View 1 chunk +0 lines, -11 lines 0 comments Download
D src/base/format-macros.h View 1 chunk +0 lines, -97 lines 0 comments Download
M src/base/logging.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/base/macros.h View 2 chunks +15 lines, -3 lines 0 comments Download
M src/base/platform/platform.h View 3 chunks +11 lines, -12 lines 0 comments Download
M src/compilation-statistics.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen-range-analysis.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/crankshaft/lithium-allocator.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/crankshaft/lithium-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/global-handles.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/gc-tracer.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/gc-tracer.cc View 3 chunks +29 lines, -29 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +49 lines, -47 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +14 lines, -6 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/log.cc View 9 chunks +15 lines, -13 lines 0 comments Download
M src/log-utils.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/log-utils.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/profiler/allocation-tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/profiler/strings-storage.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/snapshot/serializer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/utils.h View 3 chunks +30 lines, -11 lines 0 comments Download
M src/wasm/decoder.h View 4 chunks +6 lines, -9 lines 0 comments Download
M src/wasm/wasm-result.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/x64/disasm-x64.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M src/x87/disasm-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M test/cctest/test-log.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
JF
Created Revert of Fix printf formats
4 years, 8 months ago (2016-04-08 16:10:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867383002/1
4 years, 8 months ago (2016-04-08 16:10:28 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-08 16:10:30 UTC) #4
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-08 17:44:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867383002/1
4 years, 8 months ago (2016-04-08 18:04:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 18:05:08 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 18:05:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c4fdc2d63cc20cf66d3ef06d42187c230ec0081
Cr-Commit-Position: refs/heads/master@{#35366}

Powered by Google App Engine
This is Rietveld 408576698