src/log-utils.cc - Issue 1877453002: Fix printf formats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log-utils.cc

Issue 1877453002: Fix printf formats (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Handle ptrdiff_t format, which seems to make MSVC barf Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log-utils.cc

diff --git a/src/log-utils.cc b/src/log-utils.cc

index ff9af685d133b042cad0980358bf579d47ad3abc..a83a0aed568d7b5e6407bb3e430cc7c3c13f3189 100644

--- a/src/log-utils.cc

+++ b/src/log-utils.cc

@@ -164,11 +164,7 @@ void Log::MessageBuilder::Append(String* str) {

}

-void Log::MessageBuilder::AppendAddress(Address addr) {

- Append("0x%" V8PRIxPTR, addr);

+void Log::MessageBuilder::AppendAddress(Address addr) { Append("%p", addr); }

void Log::MessageBuilder::AppendSymbolName(Symbol* symbol) {

DCHECK(symbol);

« no previous file with comments | « src/log-utils.h ('k') | src/profiler/allocation-tracker.cc » ('j') | no next file with comments »