src/crankshaft/lithium-codegen.h - Issue 1877453002: Fix printf formats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/lithium-codegen.h

Issue 1877453002: Fix printf formats (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Handle ptrdiff_t format, which seems to make MSVC barf Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/lithium-codegen.h

diff --git a/src/crankshaft/lithium-codegen.h b/src/crankshaft/lithium-codegen.h

index b1f7dac2e59cd912543b54629bb783a15630514a..5d8a6fbf652fb1271e3e255d6edac9f18e5de8ba 100644

--- a/src/crankshaft/lithium-codegen.h

+++ b/src/crankshaft/lithium-codegen.h

@@ -33,7 +33,7 @@ class LCodeGenBase BASE_EMBEDDED {

LPlatformChunk* chunk() const { return chunk_; }

HGraph* graph() const;

- void FPRINTF_CHECKING Comment(const char* format, ...);

+ void PRINTF_FORMAT(2, 3) Comment(const char* format, ...);

void DeoptComment(const Deoptimizer::DeoptInfo& deopt_info);

static Deoptimizer::DeoptInfo MakeDeoptInfo(

LInstruction* instr, Deoptimizer::DeoptReason deopt_reason);

« no previous file with comments | « src/crankshaft/lithium-allocator.h ('k') | src/disassembler.cc » ('j') | no next file with comments »