Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1873463003: Remove mojo network service. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, tfarina, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mojo network service. This isn't used now that Mandoline was removed in r374453. The new network service in chrome can't reuse this implementation since it'll have to reuse existing infrastructure. Committed: https://crrev.com/ba0cadde448a94c8e96bebb622a54d05b8a5fade Cr-Commit-Position: refs/heads/master@{#385900}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7336 lines) Patch
M components/bitmap_uploader/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/window_tree_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/web_ui_mojo_shell_test.js View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/converters/network/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/converters/network/network_type_converters.h View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/converters/network/network_type_converters.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/mojo_base.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/mojo_services.gyp View 1 chunk +0 lines, -57 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/catalog/catalog.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/catalog/catalog.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/services/catalog/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/catalog/public/interfaces/resolver.mojom View 1 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/services/network/BUILD.gn View 1 chunk +0 lines, -170 lines 0 comments Download
D mojo/services/network/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/services/network/android_hooks.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/services/network/cookie_store_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/network/cookie_store_impl.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/services/network/http_connection_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/services/network/http_connection_impl.cc View 1 chunk +0 lines, -427 lines 0 comments Download
D mojo/services/network/http_server_impl.h View 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/services/network/http_server_impl.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/services/network/http_server_unittest.cc View 1 chunk +0 lines, -701 lines 0 comments Download
D mojo/services/network/main.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/network/manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/services/network/net_adapters.h View 1 chunk +0 lines, -133 lines 0 comments Download
D mojo/services/network/net_adapters.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D mojo/services/network/net_address_type_converters.h View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/services/network/net_address_type_converters.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/services/network/network_context.h View 1 chunk +0 lines, -75 lines 0 comments Download
D mojo/services/network/network_context.cc View 1 chunk +0 lines, -199 lines 0 comments Download
D mojo/services/network/network_service_delegate.h View 1 chunk +0 lines, -75 lines 0 comments Download
D mojo/services/network/network_service_delegate.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D mojo/services/network/network_service_delegate_observer.h View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/services/network/network_service_impl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D mojo/services/network/network_service_impl.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D mojo/services/network/public/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/services/network/public/cpp/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/services/network/public/cpp/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/services/network/public/cpp/udp_socket_wrapper.h View 1 chunk +0 lines, -184 lines 0 comments Download
D mojo/services/network/public/cpp/udp_socket_wrapper.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D mojo/services/network/public/cpp/web_socket_read_queue.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/network/public/cpp/web_socket_read_queue.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D mojo/services/network/public/cpp/web_socket_write_queue.h View 1 chunk +0 lines, -48 lines 0 comments Download
D mojo/services/network/public/cpp/web_socket_write_queue.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D mojo/services/network/public/interfaces/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/services/network/public/interfaces/cookie_store.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/services/network/public/interfaces/http_connection.mojom View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/network/public/interfaces/http_message.mojom View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/network/public/interfaces/http_server.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/network/public/interfaces/net_address.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/network/public/interfaces/network_error.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +0 lines, -70 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_bound_socket.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_connected_socket.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_server_socket.mojom View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/services/network/public/interfaces/udp_socket.mojom View 1 chunk +0 lines, -120 lines 0 comments Download
D mojo/services/network/public/interfaces/url_loader.mojom View 1 chunk +0 lines, -112 lines 0 comments Download
D mojo/services/network/public/interfaces/url_loader_factory.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/services/network/public/interfaces/web_socket.mojom View 1 chunk +0 lines, -59 lines 0 comments Download
D mojo/services/network/public/interfaces/web_socket_factory.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/services/network/tcp_bound_socket_impl.h View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/services/network/tcp_bound_socket_impl.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D mojo/services/network/tcp_connected_socket_impl.h View 1 chunk +0 lines, -79 lines 0 comments Download
D mojo/services/network/tcp_connected_socket_impl.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D mojo/services/network/tcp_server_socket_impl.h View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/services/network/tcp_server_socket_impl.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D mojo/services/network/test_manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/services/network/udp_socket_impl.h View 1 chunk +0 lines, -133 lines 0 comments Download
D mojo/services/network/udp_socket_impl.cc View 1 chunk +0 lines, -380 lines 0 comments Download
D mojo/services/network/udp_socket_unittest.cc View 1 chunk +0 lines, -652 lines 0 comments Download
D mojo/services/network/url_loader_factory_impl.h View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/services/network/url_loader_factory_impl.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/services/network/url_loader_impl.h View 1 chunk +0 lines, -80 lines 0 comments Download
D mojo/services/network/url_loader_impl.cc View 1 chunk +0 lines, -426 lines 0 comments Download
D mojo/services/network/url_loader_impl_unittest.cc View 1 chunk +0 lines, -287 lines 0 comments Download
D mojo/services/network/web_socket_factory_impl.h View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/services/network/web_socket_factory_impl.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/services/network/web_socket_impl.h View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/services/network/web_socket_impl.cc View 1 chunk +0 lines, -242 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 chunk +0 lines, -3 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jam
4 years, 8 months ago (2016-04-07 18:59:04 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-07 19:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873463003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873463003/40001
4 years, 8 months ago (2016-04-07 20:10:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/193267)
4 years, 8 months ago (2016-04-07 21:22:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873463003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873463003/40001
4 years, 8 months ago (2016-04-07 21:49:10 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-07 22:20:30 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 22:22:50 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ba0cadde448a94c8e96bebb622a54d05b8a5fade
Cr-Commit-Position: refs/heads/master@{#385900}

Powered by Google App Engine
This is Rietveld 408576698