Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1870553002: Revert of Track GL buffer state based on unique resource ID (Closed)

Created:
4 years, 8 months ago by mtklein
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Track GL buffer state based on unique resource ID (patchset #6 id:100001 of https://codereview.chromium.org/1854283004/ ) Reason for revert: Chrome roll's broken, seems to be missing fTarget: https://codereview.chromium.org/1861473005 Original issue's description: > Track GL buffer state based on unique resource ID > > Reworks GrGLGpu to track GL buffer state based on the unique > GrGpuResource ID. This eliminates the need to notify the gpu object > whenever a buffer is deleted. > > This change also allows us to remove the type specifier from GrBuffer. > At this point a buffer is just a chunk of memory, and the type > given at creation time is just a suggestion to the GL backend about > which target to bind to for updates. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854283004 > > Committed: https://skia.googlesource.com/skia/+/deacc97bc63513b5eacaf21f858727f6e8b98ce5 TBR=bsalomon@google.com,jvanverth@google.com,cdalton@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/044d3c185876f9960f07b88f068cf08d78311e33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+650 lines, -539 lines) Patch
M include/gpu/GrTypesPriv.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/gpu/GrBuffer.h View 3 chunks +9 lines, -5 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 1 chunk +1 line, -11 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLBuffer.h View 2 chunks +10 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLBuffer.cpp View 9 chunks +98 lines, -84 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 10 chunks +117 lines, -52 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 29 chunks +349 lines, -320 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 6 chunks +23 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 6 chunks +22 lines, -11 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkIndexBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkTransferBuffer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkVertexBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Track GL buffer state based on unique resource ID
4 years, 8 months ago (2016-04-07 01:24:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870553002/1
4 years, 8 months ago (2016-04-07 01:24:28 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 01:24:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/044d3c185876f9960f07b88f068cf08d78311e33

Powered by Google App Engine
This is Rietveld 408576698