Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1857003003: [Telemetry] Rename translate_common_values + add none_value/description support (Closed)

Created:
4 years, 8 months ago by eakuefner
Modified:
4 years, 8 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Rename translate_common_values + add none_value/description support This CL: 1. Renames translate_common_values to common_value_helpers 2. Adds none_value handling for scalars 3. Adds description handling for scalars 4. Adds unit tests for scalars. Closes #2217. Closes #2213. BUG=catapult:#2217,catapult:#2213 R=nednguyen Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/cfc61b76a63ebab69d62cbc80e92c8d727f74a8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -79 lines) Patch
A + telemetry/telemetry/value/common_value_helpers.py View 2 chunks +7 lines, -1 line 0 comments Download
A telemetry/telemetry/value/common_value_helpers_unittest.py View 1 chunk +87 lines, -0 lines 0 comments Download
D telemetry/telemetry/value/translate_common_values.py View 1 chunk +0 lines, -39 lines 0 comments Download
D telemetry/telemetry/value/translate_common_values_unittest.py View 1 chunk +0 lines, -35 lines 0 comments Download
M telemetry/telemetry/web_perf/timeline_based_measurement.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eakuefner
PTAL.
4 years, 8 months ago (2016-04-05 17:53:07 UTC) #1
nednguyen
lgtm
4 years, 8 months ago (2016-04-05 17:58:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857003003/1
4 years, 8 months ago (2016-04-05 17:58:42 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:18:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698