Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: telemetry/telemetry/value/common_value_helpers.py

Issue 1857003003: [Telemetry] Rename translate_common_values + add none_value/description support (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/value/common_value_helpers_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/value/common_value_helpers.py
diff --git a/telemetry/telemetry/value/translate_common_values.py b/telemetry/telemetry/value/common_value_helpers.py
similarity index 83%
rename from telemetry/telemetry/value/translate_common_values.py
rename to telemetry/telemetry/value/common_value_helpers.py
index 4aadcd1dc68a0d465c39173f96dfb079e93ca867..72f4bc9922ab130952b355f9d579b018276e4bc8 100644
--- a/telemetry/telemetry/value/translate_common_values.py
+++ b/telemetry/telemetry/value/common_value_helpers.py
@@ -12,7 +12,11 @@ def TranslateMreFailure(mre_failure, page):
def TranslateScalarValue(scalar_value, page):
assert IsScalarNumericValue(scalar_value)
- scalar_value['value'] = scalar_value['numeric']['value']
+
+ value = scalar_value['numeric']['value']
+ scalar_value['value'] = value
+ if value is None:
+ scalar_value['none_value_reason'] = 'Common scalar contained None'
name = scalar_value['grouping_keys']['name']
@@ -21,6 +25,8 @@ def TranslateScalarValue(scalar_value, page):
raise ValueError('Must specify improvement direction for value ' + name)
scalar_value['units'] = unit_parts[0]
+ scalar_value['description'] = scalar_value.get('options', {}).get(
+ 'description')
if unit_parts[1] == 'biggerIsBetter':
scalar_value['improvement_direction'] = improvement_direction.UP
« no previous file with comments | « no previous file | telemetry/telemetry/value/common_value_helpers_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698