Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 1857003003: [Telemetry] Rename translate_common_values + add none_value/description support (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/value/translate_common_values_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/telemetry/telemetry/web_perf/timeline_based_measurement.py b/telemetry/telemetry/web_perf/timeline_based_measurement.py
index ff3fd142f1a384d1bab5b3658b16966aabf7d73f..ce246e45409b8cd5d19e86ba4c1188129938f015 100644
--- a/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -11,7 +11,7 @@ from telemetry.timeline import model as model_module
from telemetry.timeline import tracing_category_filter
from telemetry.timeline import tracing_config
from telemetry.value import trace
-from telemetry.value import translate_common_values
+from telemetry.value import common_value_helpers
from telemetry.web_perf.metrics import timeline_based_metric
from telemetry.web_perf.metrics import blob_timeline
from telemetry.web_perf.metrics import jitter_timeline
@@ -305,13 +305,13 @@ class TimelineBasedMeasurement(story_test.StoryTest):
failure_dicts = mre_result.failures
for d in failure_dicts:
results.AddValue(
- translate_common_values.TranslateMreFailure(d, page))
+ common_value_helpers.TranslateMreFailure(d, page))
value_dicts = mre_result.pairs.get('values', [])
for d in value_dicts:
- if translate_common_values.IsScalarNumericValue(d):
+ if common_value_helpers.IsScalarNumericValue(d):
results.AddValue(
- translate_common_values.TranslateScalarValue(d, page))
+ common_value_helpers.TranslateScalarValue(d, page))
def _ComputeLegacyTimelineBasedMetrics(self, results, trace_result):
model = model_module.TimelineModel(trace_result)
« no previous file with comments | « telemetry/telemetry/value/translate_common_values_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698