Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: telemetry/telemetry/value/translate_common_values.py

Issue 1857003003: [Telemetry] Rename translate_common_values + add none_value/description support (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/value/translate_common_values.py
diff --git a/telemetry/telemetry/value/translate_common_values.py b/telemetry/telemetry/value/translate_common_values.py
deleted file mode 100644
index 4aadcd1dc68a0d465c39173f96dfb079e93ca867..0000000000000000000000000000000000000000
--- a/telemetry/telemetry/value/translate_common_values.py
+++ /dev/null
@@ -1,39 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-from telemetry.value import failure
-from telemetry.value import improvement_direction
-from telemetry.value import scalar
-
-
-def TranslateMreFailure(mre_failure, page):
- return failure.FailureValue.FromMessage(page, mre_failure.stack)
-
-
-def TranslateScalarValue(scalar_value, page):
- assert IsScalarNumericValue(scalar_value)
- scalar_value['value'] = scalar_value['numeric']['value']
-
- name = scalar_value['grouping_keys']['name']
-
- unit_parts = scalar_value['numeric']['unit'].split('_')
- if len(unit_parts) != 2:
- raise ValueError('Must specify improvement direction for value ' + name)
-
- scalar_value['units'] = unit_parts[0]
-
- if unit_parts[1] == 'biggerIsBetter':
- scalar_value['improvement_direction'] = improvement_direction.UP
- else:
- assert unit_parts[1] == 'smallerIsBetter'
- scalar_value['improvement_direction'] = improvement_direction.DOWN
-
- scalar_value['page_id'] = page.id
- scalar_value['name'] = name
- del scalar_value['grouping_keys']['name']
- return scalar.ScalarValue.FromDict(scalar_value, {page.id: page})
-
-
-def IsScalarNumericValue(value_dict):
- return (value_dict.get('type') == 'numeric' and
- value_dict['numeric'].get('type') == 'scalar')

Powered by Google App Engine
This is Rietveld 408576698