[Telemetry] Rename translate_common_values + add none_value/description support

telemetry/telemetry/value/common_value_helpers_unittest.py

Index: telemetry/telemetry/value/common_value_helpers_unittest.py
diff --git a/telemetry/telemetry/value/common_value_helpers_unittest.py b/telemetry/telemetry/value/common_value_helpers_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..17c961b4c716a23e8dab2bbbe4e667a70c8bb7ea
--- /dev/null
+++ b/telemetry/telemetry/value/common_value_helpers_unittest.py
@@ -0,0 +1,87 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import unittest
+import os
+
+from perf_insights import function_handle
+from perf_insights.mre import failure
+from perf_insights.mre import job as job_module
+
+from telemetry import page
+from telemetry import story
+from telemetry.value import improvement_direction
+from telemetry.value import scalar
+from telemetry.value import common_value_helpers
+
+
+def _SingleFileFunctionHandle(filename, function_name, guid):
+  return function_handle.FunctionHandle(
+      modules_to_load=[function_handle.ModuleToLoad(filename=filename)],
+      function_name=function_name, guid=guid)
+
+
+class TranslateCommonValuesTest(unittest.TestCase):
+  def testTranslateMreFailure(self):
+    map_function_handle = _SingleFileFunctionHandle('foo.html', 'Foo', '2')
+    reduce_function_handle = _SingleFileFunctionHandle('bar.html', 'Bar', '3')
+    job = job_module.Job(map_function_handle, reduce_function_handle, '1')
+
+    story_set = story.StorySet(base_dir=os.path.dirname(__file__))
+    p = page.Page('http://www.foo.com/', story_set, story_set.base_dir)
+
+    f = failure.Failure(job, 'foo', '/a.json', 'MyFailure', 'failure', 'stack')
+    fv = common_value_helpers.TranslateMreFailure(f, p)
+
+    self.assertIn('stack', str(fv))
+
+  def testTranslateScalarValue(self):
+    story_set = story.StorySet(base_dir=os.path.dirname(__file__))
+    p = page.Page('http://www.foo.com/', story_set, story_set.base_dir)
+
+    scalar_value = {
+        'type': 'numeric',
+        'numeric': {
+            'type': 'scalar',
+            'unit': 'timeInMs_smallerIsBetter',
+            'value': 42
+        },
+        'grouping_keys': {
+            'name': 'foo'
+        },
+        'options': {
+            'description': 'desc'
+        }
+    }
+
+    v = common_value_helpers.TranslateScalarValue(scalar_value, p)
+
+    self.assertIsInstance(v, scalar.ScalarValue)
+    self.assertEquals('foo', v.name)
+    self.assertEquals(p, v.page)
+    self.assertEquals('timeInMs', v.units)
+    self.assertEquals(42, v.value)
+    self.assertEquals(improvement_direction.DOWN, v.improvement_direction)
+    self.assertEquals('desc', v.description)
+
+  def testTranslateScalarNoneValue(self):
+    story_set = story.StorySet(base_dir=os.path.dirname(__file__))
+    p = page.Page('http://www.foo.com/', story_set, story_set.base_dir)
+
+    scalar_value = {
+        'type': 'numeric',
+        'numeric': {
+            'type': 'scalar',
+            'unit': 'timeInMs_smallerIsBetter',
+            'value': None
+        },
+        'grouping_keys': {
+            'name': 'foo'
+        }
+    }
+
+    v = common_value_helpers.TranslateScalarValue(scalar_value, p)
+
+    self.assertIsNone(v.value)
+    self.assertEquals('Common scalar contained None', v.none_value_reason)