Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1855413002: Record UMA for parser blocking time for scripts inserted via doc.write (Closed)

Created:
4 years, 8 months ago by Bryan McQuade
Modified:
4 years, 8 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@docwritetiming
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record UMA for parser blocking time for scripts inserted via doc.write. This is an important metric for Project NeverIdle: https://docs.google.com/document/d/1vUqy6uke6U1nalT6qlHbzl1LaXPHn9fLSXxGgUbMAxA/edit BUG=588724 Committed: https://crrev.com/6b1149d34b4e5ccd19f033c246d6573f34e8c74e Cr-Commit-Position: refs/heads/master@{#385863}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 4 chunks +24 lines, -0 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M components/page_load_metrics/common/page_load_metrics_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/page_load_metrics/common/page_load_timing.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M components/page_load_metrics/common/page_load_timing.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/page_load_metrics/renderer/metrics_render_frame_observer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Bryan McQuade
csharrison, PTAL for page_load_metrics asvitkine, PTAL for histograms.xml Thanks!
4 years, 8 months ago (2016-04-05 15:57:09 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-05 21:22:42 UTC) #4
Charlie Harrison
lgtm
4 years, 8 months ago (2016-04-06 12:37:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855413002/80001
4 years, 8 months ago (2016-04-07 20:32:57 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-07 21:22:38 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:29:56 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6b1149d34b4e5ccd19f033c246d6573f34e8c74e
Cr-Commit-Position: refs/heads/master@{#385863}

Powered by Google App Engine
This is Rietveld 408576698