components/page_load_metrics/common/page_load_timing.cc - Issue 1855413002: Record UMA for parser blocking time for scripts inserted via doc.write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/common/page_load_timing.cc

Issue 1855413002: Record UMA for parser blocking time for scripts inserted via doc.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@docwritetiming

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/common/page_load_timing.h ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/common/page_load_timing.cc

diff --git a/components/page_load_metrics/common/page_load_timing.cc b/components/page_load_metrics/common/page_load_timing.cc

index bc9d0b827194e072a29fd108ff0a246e0568c98c..7c368204551f40d17cc50dbd3d55f22e85aab254 100644

--- a/components/page_load_metrics/common/page_load_timing.cc

+++ b/components/page_load_metrics/common/page_load_timing.cc

@@ -25,7 +25,9 @@ bool PageLoadTiming::operator==(const PageLoadTiming& other) const {

first_image_paint == other.first_image_paint &&

parse_start == other.parse_start && parse_stop == other.parse_stop &&

parse_blocked_on_script_load_duration ==

- other.parse_blocked_on_script_load_duration;

+ other.parse_blocked_on_script_load_duration &&

+ parse_blocked_on_script_load_from_document_write_duration ==

+ other.parse_blocked_on_script_load_from_document_write_duration;

}

bool PageLoadTiming::IsEmpty() const {

@@ -35,7 +37,8 @@ bool PageLoadTiming::IsEmpty() const {

first_paint.is_zero() && first_text_paint.is_zero() &&

first_image_paint.is_zero() && parse_start.is_zero() &&

parse_stop.is_zero() &&

- parse_blocked_on_script_load_duration.is_zero();

+ parse_blocked_on_script_load_duration.is_zero() &&

+ parse_blocked_on_script_load_from_document_write_duration.is_zero();

}

} // namespace page_load_metrics