Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4437)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 1855413002: Record UMA for parser blocking time for scripts inserted via doc.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@docwritetiming
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 205c79f21053f648b0b1de979f0be8d38331f6c3..148ee64622f2ba6eed00bd1b56a6fa76f5cb1ffd 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -63,6 +63,10 @@ const char kHistogramParseBlockedOnScriptLoad[] =
"PageLoad.Timing2.ParseBlockedOnScriptLoad";
const char kHistogramParseBlockedOnScriptLoadParseComplete[] =
"PageLoad.Timing2.ParseBlockedOnScriptLoad.ParseComplete";
+const char kHistogramParseBlockedOnScriptLoadDocumentWrite[] =
+ "PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite";
+const char kHistogramParseBlockedOnScriptLoadDocumentWriteParseComplete[] =
+ "PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite.ParseComplete";
const char kBackgroundHistogramCommit[] =
"PageLoad.Timing2.NavigationToCommit.Background";
@@ -86,6 +90,12 @@ const char kBackgroundHistogramParseBlockedOnScriptLoad[] =
"PageLoad.Timing2.ParseBlockedOnScriptLoad.Background";
const char kBackgroundHistogramParseBlockedOnScriptLoadParseComplete[] =
"PageLoad.Timing2.ParseBlockedOnScriptLoad.ParseComplete.Background";
+const char kBackgroundHistogramParseBlockedOnScriptLoadDocumentWrite[] =
+ "PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite.Background";
+const char
+ kBackgroundHistogramParseBlockedOnScriptLoadDocumentWriteParseComplete[] =
+ "PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite."
+ "ParseComplete.Background";
const char kHistogramFirstContentfulPaintHigh[] =
"PageLoad.Timing2.NavigationToFirstContentfulPaint.HighResolutionClock";
@@ -290,10 +300,16 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(
WasStartedInForegroundEventInForeground(timing.parse_stop, info)) {
PAGE_LOAD_HISTOGRAM(internal::kHistogramParseBlockedOnScriptLoad,
timing.parse_blocked_on_script_load_duration);
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramParseBlockedOnScriptLoadDocumentWrite,
+ timing.parse_blocked_on_script_load_from_document_write_duration);
} else {
PAGE_LOAD_HISTOGRAM(
internal::kBackgroundHistogramParseBlockedOnScriptLoad,
timing.parse_blocked_on_script_load_duration);
+ PAGE_LOAD_HISTOGRAM(
+ internal::kBackgroundHistogramParseBlockedOnScriptLoadDocumentWrite,
+ timing.parse_blocked_on_script_load_from_document_write_duration);
}
}
if (!timing.parse_stop.is_zero()) {
@@ -303,12 +319,20 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(
PAGE_LOAD_HISTOGRAM(
internal::kHistogramParseBlockedOnScriptLoadParseComplete,
timing.parse_blocked_on_script_load_duration);
+ PAGE_LOAD_HISTOGRAM(
+ internal::
+ kHistogramParseBlockedOnScriptLoadDocumentWriteParseComplete,
+ timing.parse_blocked_on_script_load_from_document_write_duration);
} else {
PAGE_LOAD_HISTOGRAM(internal::kBackgroundHistogramParseDuration,
parse_duration);
PAGE_LOAD_HISTOGRAM(
internal::kBackgroundHistogramParseBlockedOnScriptLoadParseComplete,
timing.parse_blocked_on_script_load_duration);
+ PAGE_LOAD_HISTOGRAM(
+ internal::
+ kBackgroundHistogramParseBlockedOnScriptLoadDocumentWriteParseComplete,
+ timing.parse_blocked_on_script_load_from_document_write_duration);
}
}
« no previous file with comments | « no previous file | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698