Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1855413002: Record UMA for parser blocking time for scripts inserted via doc.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@docwritetiming
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
index 50f071523618a7aacccb39df8d8be58ab9d56d44..7b411cc1ba264e2b17abd428b475a8a145a236f6 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
@@ -118,6 +118,16 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
}
}
+ if (timing.parse_blocked_on_script_load_from_document_write_duration >
+ timing.parse_blocked_on_script_load_duration) {
+ NOTREACHED()
+ << "Invalid parse_blocked_on_script_load_from_document_write_duration "
+ << timing.parse_blocked_on_script_load_from_document_write_duration
+ << " for parse_blocked_on_script_load_duration "
+ << timing.parse_blocked_on_script_load_duration;
+ return false;
+ }
+
if (!EventsInOrder(timing.dom_loading,
timing.dom_content_loaded_event_start)) {
NOTREACHED() << "Invalid dom_loading " << timing.dom_loading

Powered by Google App Engine
This is Rietveld 408576698