Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: components/page_load_metrics/common/page_load_timing.h

Issue 1855413002: Record UMA for parser blocking time for scripts inserted via doc.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@docwritetiming
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/common/page_load_timing.h
diff --git a/components/page_load_metrics/common/page_load_timing.h b/components/page_load_metrics/common/page_load_timing.h
index 3b1df5e364205d7066b106e701f5cbcd88cdca6e..da1ce89917d0fe1155f25e691bedf35ce2c968da 100644
--- a/components/page_load_metrics/common/page_load_timing.h
+++ b/components/page_load_metrics/common/page_load_timing.h
@@ -62,6 +62,13 @@ struct PageLoadTiming {
// must be less than or equal to parser_stop - parser_start.
base::TimeDelta parse_blocked_on_script_load_duration;
+ // Sum of times when the parser is blocked waiting on the load of a script
+ // that was inserted from document.write. This duration must be less than or
+ // equal to parse_blocked_on_script_load_duration. Note that some uncommon
+ // cases where scripts are loaded via document.write are not currently covered
+ // by this field. See crbug/600711 for details.
+ base::TimeDelta parse_blocked_on_script_load_from_document_write_duration;
+
// If you add additional members, also be sure to update operator==,
// page_load_metrics_messages.h, and IsEmpty().
};

Powered by Google App Engine
This is Rietveld 408576698