Convert //base to use std::unique_ptr

Convert //base to use std::unique_ptr

With bonus IWYU fixes that weren't caught by local android gn, cros gn,
linux gn, mac gyp, and win gyp builds.

BUG=554298
TBR=brettw@chromium.org

Committed: https://crrev.com/093de9b30c0ba6ded896506a297314e5ed818b89
Cr-Commit-Position: refs/heads/master@{#385011}

[dcheng, 2016-04-01 18:33:54]

dcheng@chromium.org changed reviewers:
+ mark@chromium.org

[dcheng, 2016-04-01 18:33:56]

For the header additions/removals, I did a more thorough check to make sure
things like Windows headers didn't get moved around, since that tends to break
things.

For scoped_ptr -> std::unique_ptr and make_scoped_ptr -> base::WrapUnique(), I
did a spot check and things seem sane (and still compile).

[Mark Mentovai, 2016-04-01 18:49:30]

Waiting for trybot results. Poke this again when they’re all green.

[dcheng, 2016-04-01 18:58:02]

Bah, these are all IWYU failures: some file didn't include scoped_ptr.h and got
it from some base header.

Let me see how intractable fixing this will be, I have some scripts that help
with this, but it's probably still going to be a giant mess at the end of the
day.

[danakj, 2016-04-01 18:59:01]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-04-01 18:59:02]

Since base is so widely included you might wanna go by subdirs.

[dcheng, 2016-04-01 19:02:26]

On 2016/04/01 at 18:59:02, danakj wrote:
> Since base is so widely included you might wanna go by subdirs.

Yeah, that's my fallback plan. But since I already have this patch, I'd like to
see just how bad the IWYU problem is.

[dcheng, 2016-04-04 04:55:44]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 04:55:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/100001

[commit-bot: I haz the power, 2016-04-04 05:04:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 05:04:24]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[dcheng, 2016-04-04 05:06:54]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 05:07:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/120001

[commit-bot: I haz the power, 2016-04-04 05:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 05:17:05]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[dcheng, 2016-04-04 05:36:49]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 05:36:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/160001

[commit-bot: I haz the power, 2016-04-04 05:49:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 05:49:53]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[dcheng, 2016-04-04 06:15:16]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 06:15:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/180001

[commit-bot: I haz the power, 2016-04-04 06:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 06:44:06]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[dcheng, 2016-04-04 07:46:51]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 07:46:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/200001

[dcheng, 2016-04-04 07:48:15]

Description was changed from

==========
Convert //base to use std::unique_ptr

BUG=554298
==========

to

==========
Convert //base to use std::unique_ptr

With bonus IWYU fixes that weren't caught by local android gn, cros gn,
linux gn, mac gyp, and win gyp builds.

BUG=554298
==========

[commit-bot: I haz the power, 2016-04-04 08:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 08:16:14]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dcheng, 2016-04-04 08:26:34]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 08:26:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/220001

[commit-bot: I haz the power, 2016-04-04 09:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 09:02:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dcheng, 2016-04-04 09:16:53]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 09:17:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/240001

[dcheng, 2016-04-04 09:29:16]

8 patchsets and 200+ IWYU fixes later, I think this probably compiles. Probably.
PTAL.

[Primiano Tucci (use gerrit), 2016-04-04 10:20:34]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-04-04 10:20:37]

Took a look to base/trace_event, one question:
FYI some of the trace_event headers are used by blink, would that be a problem
for this CL? (I guess not, but just doublechecking, didn't follow all the
transition)

P.S: You has some redundant base:: prefix in base::WrapUnique, but I guess they
just came from some automagic tool. Didn't look at the rest but I'm happy to
cleanup them from base/trace_event myself after this CL.


Thanks a lot for this, folks! Oh, fwiw //base/trace_event lgtm.

https://codereview.chromium.org/1852433005/diff/240001/base/trace_event/heap_...
File base/trace_event/heap_profiler_heap_dump_writer_unittest.cc (right):

https://codereview.chromium.org/1852433005/diff/240001/base/trace_event/heap_...
base/trace_event/heap_profiler_heap_dump_writer_unittest.cc:205: auto
sf_deduplicator = base::WrapUnique(new StackFrameDeduplicator);
this is already in namespace base{, so in theory doesn't require base::.
But whatever, I imagine this is somehow automated, I can cleanup
//base/trace_event after your mega-CL :)

[commit-bot: I haz the power, 2016-04-04 11:12:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 11:12:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dcheng, 2016-04-04 16:20:59]

For the most part, Blink doesn't use scoped_ptr so it's usually not a problem.
There was one Blink file this broke, and that's already been separately fixed in
https://chromium.googlesource.com/chromium/src/+/556abd1195e93af420426e3e1f50...

PTAL

https://codereview.chromium.org/1852433005/diff/240001/base/trace_event/heap_...
File base/trace_event/heap_profiler_heap_dump_writer_unittest.cc (right):

https://codereview.chromium.org/1852433005/diff/240001/base/trace_event/heap_...
base/trace_event/heap_profiler_heap_dump_writer_unittest.cc:205: auto
sf_deduplicator = base::WrapUnique(new StackFrameDeduplicator);
On 2016/04/04 at 10:20:36, Primiano Tucci wrote:
> this is already in namespace base{, so in theory doesn't require base::.
> But whatever, I imagine this is somehow automated, I can cleanup
//base/trace_event after your mega-CL :)

Good point, done.

[dcheng, 2016-04-04 16:21:06]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 16:21:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/260001

[Primiano Tucci (use gerrit), 2016-04-04 16:27:47]

On 2016/04/04 16:20:59, dcheng wrote:
> For the most part, Blink doesn't use scoped_ptr so it's usually not a problem.
I was thinking to these:
- src/third_party/WebKit/Source/platform/TracedValue.h
- src/third_party/WebKit/Source/platform/EventTracer.h
- src/third_party/WebKit/Source/platform/TracedValueTest.cpp

But I guess they are just fine and will be fixed by some next iteration.

> There was one Blink file this broke, and that's already been separately fixed
in
>
https://chromium.googlesource.com/chromium/src/+/556abd1195e93af420426e3e1f50...

Right I think what I was worried was side-effect of removing #includes, but you
seem to have fixed that already :)

[commit-bot: I haz the power, 2016-04-04 16:34:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 16:34:14]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Nico, 2016-04-04 16:39:28]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-04-04 16:39:30]

ios and cast red trybots look real

[dcheng, 2016-04-04 17:09:19]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 17:09:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/280001

[dcheng, 2016-04-04 17:09:50]

On 2016/04/04 at 16:39:30, thakis wrote:
> ios and cast red trybots look real

Fixed the broken test compile by adding a namespace base { ... } block to it.
PTAL.

[Nico, 2016-04-04 17:14:56]

base/ basically lgtm. I didn't understand that you're adding <memory> if and
only if a file had a scoped_ptr include until a few files in, so ignore the
first few "iwyu memory" comments. I did leave a few comments where the new
<memory> include looked unused; addressing those probably makes sense.

I didn't understand the changes outside of base. I'm guessing you're adding
scoped_ptr there because these headers require some of the headers that
scoped_ptr includes. Shouldn't you add those headers directly instead? As-is,
this looks like it creates more work for you when you want to later delete
scoped_ptr.h (but if you want to do this in stages, then the approach in this cl
is fine).

https://codereview.chromium.org/1852433005/diff/260001/base/containers/mru_ca...
File base/containers/mru_cache_unittest.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/containers/mru_ca...
base/containers/mru_cache_unittest.cc:9: #include <memory>
(nit: in a previous file that included ptr_util, you didn't include <memory>; i
figured the reasoning there was that ptr_util must include <memory>. anyhoo,
fine as-is, but the cl isn't self-consistent on this as far as i can tell)

https://codereview.chromium.org/1852433005/diff/260001/base/debug/stack_trace...
File base/debug/stack_trace_posix.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/debug/stack_trace...
base/debug/stack_trace_posix.cc:183: std::unique_ptr<char*, FreeDeleter>
trace_symbols(
(file doesn't iwyu for freedeleter i think)

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util.cc
File base/files/file_util.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util.c...
base/files/file_util.cc:13: #include <limits>
(nit: iwyu memory)

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util.h
File base/files/file_util.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util.h...
base/files/file_util.h:15: #include <memory>
(unused?)

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util_p...
File base/files/file_util_posix.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util_p...
base/files/file_util_posix.cc:25: #include <memory>
unused?

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_author...
File base/mac/scoped_authorizationref.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_author...
base/mac/scoped_authorizationref.h:65: // is
manually reflow this comment (clang-format sucks at formatting comments)

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_cftype...
File base/mac/scoped_cftyperef.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_cftype...
base/mac/scoped_cftyperef.h:15: // ownership
likewise

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_nsobje...
File base/mac/scoped_nsobject.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_nsobje...
base/mac/scoped_nsobject.h:23: // ownership
likewise

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_typeref.h
File base/mac/scoped_typeref.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_typere...
base/mac/scoped_typeref.h:15: // ownership
likewise

https://codereview.chromium.org/1852433005/diff/260001/base/memory/shared_mem...
File base/memory/shared_memory_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/memory/shared_mem...
base/memory/shared_memory_win.cc:11: #include <memory>
unused?

https://codereview.chromium.org/1852433005/diff/260001/base/process/launch_wi...
File base/process/launch_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/launch_wi...
base/process/launch_win.cc:16: #include <memory>
unused

https://codereview.chromium.org/1852433005/diff/260001/base/process/memory_wi...
File base/process/memory_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/memory_wi...
base/process/memory_win.cc:11: #include <memory>
unused

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_h...
File base/process/process_handle_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_h...
base/process/process_handle_win.cc:10: #include <memory>
unused

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_u...
File base/process/process_util_unittest.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_u...
base/process/process_util_unittest.cc:11: #include <memory>
unused

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_w...
File base/process/process_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_w...
base/process/process_win.cc:7: #include <memory>
unused

https://codereview.chromium.org/1852433005/diff/260001/base/sys_info_win.cc
File base/sys_info_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/sys_info_win.cc#n...
base/sys_info_win.cc:12: #include <memory>
unused

https://codereview.chromium.org/1852433005/diff/260001/base/trace_event/winhe...
File base/trace_event/winheap_dump_provider_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/trace_event/winhe...
base/trace_event/winheap_dump_provider_win.cc:84: if
(::GetProcessHeaps(number_of_heaps, all_heaps.get()) != number_of_heaps)
(i was wondering if this leaks the contents of all_heaps and found
https://blogs.msdn.microsoft.com/oldnewthing/20110701-00/?p=10273 , which makes
me a bit uneasy about this code...)

https://codereview.chromium.org/1852433005/diff/260001/chrome/browser/android...
File chrome/browser/android/bottombar/overlay_panel_content.h (right):

https://codereview.chromium.org/1852433005/diff/260001/chrome/browser/android...
chrome/browser/android/bottombar/overlay_panel_content.h:10: #include
"base/memory/scoped_ptr.h"
a) unused
b) why does this add scoped_ptr, not memory?

https://codereview.chromium.org/1852433005/diff/260001/chrome/browser/chromeo...
File chrome/browser/chromeos/file_manager/fileapi_util.h (right):

https://codereview.chromium.org/1852433005/diff/260001/chrome/browser/chromeo...
chrome/browser/chromeos/file_manager/fileapi_util.h:15: #include
"base/memory/scoped_ptr.h"
same question. iwyu for other stuff pulled in from scoped_ptr? should you
include those instead?

[dcheng, 2016-04-04 17:43:39]

Note that pretty much all the new #include scoped_ptr.h lines outside //base are
directly due to those files not including scoped_ptr.h when they should have
been.

https://codereview.chromium.org/1852433005/diff/260001/base/containers/mru_ca...
File base/containers/mru_cache_unittest.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/containers/mru_ca...
base/containers/mru_cache_unittest.cc:9: #include <memory>
On 2016/04/04 at 17:14:55, Nico wrote:
> (nit: in a previous file that included ptr_util, you didn't include <memory>;
i figured the reasoning there was that ptr_util must include <memory>. anyhoo,
fine as-is, but the cl isn't self-consistent on this as far as i can tell)

The automated rules are this:
- scoped_ptr.h, if present, gets rewritten to <memory>
- if the file references WrapUnique, the header ptr_util.h is inserted.
- if something outside //base failed to compile, that means they forgot to IWYU
for scoped_ptr.h and so they get an #include for scoped_ptr.h.

I didn't attempt to get fancier than that. AFAIK, there are no formal rules
around when a translation unit can assume an included header exposes another
header as a public dep (e.g. ptr_util.h exposing <memory>). I could try to make
it self-consistent, but given the current lack of any automated enforcement,
it's just going to quickly revert to the status quo. So I don't think it's worth
the additional work it'd entail.

https://codereview.chromium.org/1852433005/diff/260001/base/debug/stack_trace...
File base/debug/stack_trace_posix.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/debug/stack_trace...
base/debug/stack_trace_posix.cc:183: std::unique_ptr<char*, FreeDeleter>
trace_symbols(
On 2016/04/04 at 17:14:55, Nico wrote:
> (file doesn't iwyu for freedeleter i think)

Note that this CL isn't attempt to address IWYU globally for everything. I'm
thinking about formulating something to make this situation less insane in the
future, but nothing concrete yet.

For this particular issue, the header is already present, just in the wrong
section. I've moved it.

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util.h
File base/files/file_util.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util.h...
base/files/file_util.h:15: #include <memory>
On 2016/04/04 at 17:14:55, Nico wrote:
> (unused?)

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util_p...
File base/files/file_util_posix.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/files/file_util_p...
base/files/file_util_posix.cc:25: #include <memory>
On 2016/04/04 at 17:14:55, Nico wrote:
> unused?

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_author...
File base/mac/scoped_authorizationref.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_author...
base/mac/scoped_authorizationref.h:65: // is
On 2016/04/04 at 17:14:55, Nico wrote:
> manually reflow this comment (clang-format sucks at formatting comments)

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_cftype...
File base/mac/scoped_cftyperef.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_cftype...
base/mac/scoped_cftyperef.h:15: // ownership
On 2016/04/04 at 17:14:56, Nico wrote:
> likewise

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_nsobje...
File base/mac/scoped_nsobject.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_nsobje...
base/mac/scoped_nsobject.h:23: // ownership
On 2016/04/04 at 17:14:56, Nico wrote:
> likewise

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_typeref.h
File base/mac/scoped_typeref.h (right):

https://codereview.chromium.org/1852433005/diff/260001/base/mac/scoped_typere...
base/mac/scoped_typeref.h:15: // ownership
On 2016/04/04 at 17:14:56, Nico wrote:
> likewise

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/memory/shared_mem...
File base/memory/shared_memory_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/memory/shared_mem...
base/memory/shared_memory_win.cc:11: #include <memory>
On 2016/04/04 at 17:14:56, Nico wrote:
> unused?

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/process/launch_wi...
File base/process/launch_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/launch_wi...
base/process/launch_win.cc:16: #include <memory>
On 2016/04/04 at 17:14:56, Nico wrote:
> unused

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/process/memory_wi...
File base/process/memory_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/memory_wi...
base/process/memory_win.cc:11: #include <memory>
On 2016/04/04 at 17:14:56, Nico wrote:
> unused

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_h...
File base/process/process_handle_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_h...
base/process/process_handle_win.cc:10: #include <memory>
On 2016/04/04 at 17:14:56, Nico wrote:
> unused

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_u...
File base/process/process_util_unittest.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_u...
base/process/process_util_unittest.cc:11: #include <memory>
On 2016/04/04 at 17:14:56, Nico wrote:
> unused

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_w...
File base/process/process_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/process/process_w...
base/process/process_win.cc:7: #include <memory>
On 2016/04/04 at 17:14:56, Nico wrote:
> unused

Done.

https://codereview.chromium.org/1852433005/diff/260001/base/sys_info_win.cc
File base/sys_info_win.cc (right):

https://codereview.chromium.org/1852433005/diff/260001/base/sys_info_win.cc#n...
base/sys_info_win.cc:12: #include <memory>
On 2016/04/04 at 17:14:56, Nico wrote:
> unused

Done. While it is nice to clean these up, I don't have a simple incantation to
do it. If anyone has thoughts, it would be a useful addition to
https://docs.google.com/spreadsheets/d/19zyXGmZzdn9muv8ldpfOrgPaiHsxL4OHyGcnK....

https://codereview.chromium.org/1852433005/diff/260001/chrome/browser/android...
File chrome/browser/android/bottombar/overlay_panel_content.h (right):

https://codereview.chromium.org/1852433005/diff/260001/chrome/browser/android...
chrome/browser/android/bottombar/overlay_panel_content.h:10: #include
"base/memory/scoped_ptr.h"
On 2016/04/04 at 17:14:56, Nico wrote:
> a) unused
> b) why does this add scoped_ptr, not memory?

The IWYU fixes were all automated using a poor man's version of IWYU (basically
I have a script that runs in a loop trying to build: every time it hits a
compile error, it blindly inserts an #include for scoped_ptr.h). Trying to
convert these over to std::unique_ptr<T> as well is mostly a non-goal in this
CL, since I wanted to limit the scope of the actual conversion to //base. It's
just that //base is widely used and a common avenue for IWYU violations.

While it's possible this will introduce some scoped_ptr usage in
already-converted directories, that's easy enough to clean up in the final pass.

Also, it's not unused, see line 69.

https://codereview.chromium.org/1852433005/diff/260001/chrome/browser/chromeo...
File chrome/browser/chromeos/file_manager/fileapi_util.h (right):

https://codereview.chromium.org/1852433005/diff/260001/chrome/browser/chromeo...
chrome/browser/chromeos/file_manager/fileapi_util.h:15: #include
"base/memory/scoped_ptr.h"
On 2016/04/04 at 17:14:56, Nico wrote:
> same question. iwyu for other stuff pulled in from scoped_ptr? should you
include those instead?

See previous comment.

[dcheng, 2016-04-04 17:44:23]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 17:44:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/300001

[Mark Mentovai, 2016-04-04 17:53:10]

I would have thought that the best way to approach the transition in this change
would have been to #include <memory> in base/memory/scoped_ptr.h. That should
take care of everything outside of base that was picking up scoped_ptr.h,
whether it was picking it up correctly per IWYU or just by chance.

But if what you’ve got now works, and it doesn’t become more of a wild goose
chase, then I’d call this LG.

If the goose chase becomes much more wild, you should strongly consider adding a
fallback #include to one file in base if possible, instead of having to chase
things down all over the tree right now. Now’s not the time to chase things down
if you can defer it to changes that fix up the rest of the tree to use
unique_ptr.

[Nico, 2016-04-04 17:56:38]

lgtm

[dcheng, 2016-04-04 18:10:10]

On 2016/04/04 at 17:53:10, mark wrote:
> I would have thought that the best way to approach the transition in this
change would have been to #include <memory> in base/memory/scoped_ptr.h. That
should take care of everything outside of base that was picking up scoped_ptr.h,
whether it was picking it up correctly per IWYU or just by chance.

It already does #include <memory>; the problem is files that #include
"base/callback.h" and then use scoped_ptr: this worked today, since one of
base/callback.h's transitive dependencies is scoped_ptr, but doesn't work once
//base no longer has any #includes for scoped_ptr.h.

> 
> But if what you’ve got now works, and it doesn’t become more of a wild goose
chase, then I’d call this LG.
> 
> If the goose chase becomes much more wild, you should strongly consider adding
a fallback #include to one file in base if possible, instead of having to chase
things down all over the tree right now. Now’s not the time to chase things down
if you can defer it to changes that fix up the rest of the tree to use
unique_ptr.

This was essentially an experiment to see how bad the problem was/is. The
current recommendation for future work is to just start at the leaf nodes and
work up from there, thereby avoiding the IWYU question altogether. I'm hoping
that this will eventually be in a better place though...

[Mark Mentovai, 2016-04-04 18:15:31]

OK. I think that enough bots are turning green already that we can call this
LGTM, and you can land this when they’re all green. Obviously if the goose chase
gets too bad, we can revisit.

[dcheng, 2016-04-04 18:55:59]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-04 18:56:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, mark@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1852433005/#ps320001
(title: "Meh")

[commit-bot: I haz the power, 2016-04-04 18:56:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/320001

[commit-bot: I haz the power, 2016-04-04 19:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:02:38]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dcheng, 2016-04-04 19:19:34]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-04 19:19:36]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
thakis@chromium.org, primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1852433005/#ps340001
(title: "rebase after r384946")

[commit-bot: I haz the power, 2016-04-04 19:20:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/340001

[commit-bot: I haz the power, 2016-04-04 19:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:37:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-04-04 19:37:15]

Description was changed from

==========
Convert //base to use std::unique_ptr

With bonus IWYU fixes that weren't caught by local android gn, cros gn,
linux gn, mac gyp, and win gyp builds.

BUG=554298
==========

to

==========
Convert //base to use std::unique_ptr

With bonus IWYU fixes that weren't caught by local android gn, cros gn,
linux gn, mac gyp, and win gyp builds.

BUG=554298
TBR=brettw@chromium.org
==========

[dcheng, 2016-04-04 19:37:28]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-04 19:37:31]

TBRing brettw@ for global owners stamp for IWYU fixes.

[dcheng, 2016-04-04 19:37:42]

dcheng@chromium.org changed reviewers:
+ brettw@chromium.org

[dcheng, 2016-04-04 19:37:45]

Really +brettw for TBR this time.

[commit-bot: I haz the power, 2016-04-04 19:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433005/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433005/340001

[commit-bot: I haz the power, 2016-04-04 21:26:07]

Committed patchset #18 (id:340001)

[commit-bot: I haz the power, 2016-04-04 21:28:02]

Description was changed from

==========
Convert //base to use std::unique_ptr

With bonus IWYU fixes that weren't caught by local android gn, cros gn,
linux gn, mac gyp, and win gyp builds.

BUG=554298
TBR=brettw@chromium.org
==========

to

==========
Convert //base to use std::unique_ptr

With bonus IWYU fixes that weren't caught by local android gn, cros gn,
linux gn, mac gyp, and win gyp builds.

BUG=554298
TBR=brettw@chromium.org

Committed: https://crrev.com/093de9b30c0ba6ded896506a297314e5ed818b89
Cr-Commit-Position: refs/heads/master@{#385011}
==========

[commit-bot: I haz the power, 2016-04-04 21:28:05]

Patchset 18 (id:??) landed as
https://crrev.com/093de9b30c0ba6ded896506a297314e5ed818b89
Cr-Commit-Position: refs/heads/master@{#385011}