base/metrics/persistent_sample_map.h - Issue 1852433005: Convert //base to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_sample_map.h

Issue 1852433005: Convert //base to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase after r384946 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/persistent_sample_map.h

diff --git a/base/metrics/persistent_sample_map.h b/base/metrics/persistent_sample_map.h

index a23b751804d6067611b62d1e41232310591e475c..4ae54d8ae26f79af86d010deedc057fa759e3840 100644

--- a/base/metrics/persistent_sample_map.h

+++ b/base/metrics/persistent_sample_map.h

@@ -12,10 +12,10 @@

#include <stdint.h>

#include <map>

+#include <memory>

#include "base/compiler_specific.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram_base.h"

#include "base/metrics/histogram_samples.h"

#include "base/metrics/persistent_memory_allocator.h"

@@ -36,7 +36,7 @@ class BASE_EXPORT PersistentSampleMap : public HistogramSamples {

HistogramBase::Count count) override;

HistogramBase::Count GetCount(HistogramBase::Sample value) const override;

HistogramBase::Count TotalCount() const override;

- scoped_ptr<SampleCountIterator> Iterator() const override;

+ std::unique_ptr<SampleCountIterator> Iterator() const override;

protected:

// Performs arithemetic. |op| is ADD or SUBTRACT.