base/trace_event/java_heap_dump_provider_android_unittest.cc - Issue 1852433005: Convert //base to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/java_heap_dump_provider_android_unittest.cc

Issue 1852433005: Convert //base to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase after r384946 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/java_heap_dump_provider_android_unittest.cc

diff --git a/base/trace_event/java_heap_dump_provider_android_unittest.cc b/base/trace_event/java_heap_dump_provider_android_unittest.cc

index 35f3f17fbb1dee2407760a47a13895cb8626198d..6b31bd6e9f5e2693e7c9dff45b0a1e0c05a834a0 100644

--- a/base/trace_event/java_heap_dump_provider_android_unittest.cc

+++ b/base/trace_event/java_heap_dump_provider_android_unittest.cc

@@ -12,7 +12,7 @@ namespace trace_event {

TEST(JavaHeapDumpProviderTest, JavaHeapDump) {

auto jhdp = JavaHeapDumpProvider::GetInstance();

- scoped_ptr<ProcessMemoryDump> pmd(new ProcessMemoryDump(nullptr));

+ std::unique_ptr<ProcessMemoryDump> pmd(new ProcessMemoryDump(nullptr));

MemoryDumpArgs dump_args = {MemoryDumpLevelOfDetail::DETAILED};

jhdp->OnMemoryDump(dump_args, pmd.get());