base/trace_event/malloc_dump_provider.h - Issue 1852433005: Convert //base to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/malloc_dump_provider.h

Issue 1852433005: Convert //base to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase after r384946 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/malloc_dump_provider.h

diff --git a/base/trace_event/malloc_dump_provider.h b/base/trace_event/malloc_dump_provider.h

index d9d702176a44057ea4fcb04f1aca4c844ac45d24..4746cf589680040c6692499c892c4f28504f4091 100644

--- a/base/trace_event/malloc_dump_provider.h

+++ b/base/trace_event/malloc_dump_provider.h

@@ -6,9 +6,9 @@

#define BASE_TRACE_EVENT_MALLOC_DUMP_PROVIDER_H_

#include <istream>

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/singleton.h"

#include "base/synchronization/lock.h"

#include "base/threading/platform_thread.h"

@@ -52,7 +52,7 @@ class BASE_EXPORT MallocDumpProvider : public MemoryDumpProvider {

// For heap profiling.

bool heap_profiler_enabled_;

- scoped_ptr<AllocationRegister> allocation_register_;

+ std::unique_ptr<AllocationRegister> allocation_register_;

Lock allocation_register_lock_;

// When in OnMemoryDump(), this contains the current thread ID.