Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1848423002: Convert //gin to use std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //gin to use std::unique_ptr BUG=554298 Committed: https://crrev.com/c862da8ac734722d6928b64ae87564bf2ee0d2ae Cr-Commit-Position: refs/heads/master@{#384830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -31 lines) Patch
M gin/converter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gin/isolate_holder.cc View 2 chunks +3 lines, -1 line 0 comments Download
M gin/modules/module_registry.h View 3 chunks +5 lines, -4 lines 0 comments Download
M gin/modules/module_registry.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M gin/modules/module_registry_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M gin/modules/timer_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M gin/per_isolate_data.h View 3 chunks +3 lines, -3 lines 0 comments Download
M gin/per_isolate_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/public/context_holder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gin/public/isolate_holder.h View 3 chunks +6 lines, -5 lines 0 comments Download
M gin/test/v8_test.h View 2 chunks +3 lines, -2 lines 0 comments Download
M gin/v8_initializer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M gin/v8_isolate_memory_dump_provider_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848423002/1
4 years, 8 months ago (2016-04-01 20:43:47 UTC) #2
Mostyn Bramley-Moore
@Jochen: please take a look.
4 years, 8 months ago (2016-04-01 22:08:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 22:39:27 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-03 11:17:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848423002/1
4 years, 8 months ago (2016-04-03 14:38:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-03 15:54:46 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-03 15:56:02 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c862da8ac734722d6928b64ae87564bf2ee0d2ae
Cr-Commit-Position: refs/heads/master@{#384830}

Powered by Google App Engine
This is Rietveld 408576698