Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: gin/modules/module_registry.h

Issue 1848423002: Convert //gin to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/isolate_holder.cc ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/module_registry.h
diff --git a/gin/modules/module_registry.h b/gin/modules/module_registry.h
index 0f67137abb3752baaf7cb132b69f0a8aa50b7e3f..9bbfd6e0b925dc59639b4f1634dc683aa3cb8a16 100644
--- a/gin/modules/module_registry.h
+++ b/gin/modules/module_registry.h
@@ -7,13 +7,13 @@
#include <list>
#include <map>
+#include <memory>
#include <set>
#include <string>
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
#include "base/observer_list.h"
#include "gin/gin_export.h"
@@ -59,7 +59,7 @@ class GIN_EXPORT ModuleRegistry {
// The caller must have already entered our context.
void AddPendingModule(v8::Isolate* isolate,
- scoped_ptr<PendingModule> pending);
+ std::unique_ptr<PendingModule> pending);
void LoadModule(v8::Isolate* isolate,
const std::string& id,
@@ -82,13 +82,14 @@ class GIN_EXPORT ModuleRegistry {
explicit ModuleRegistry(v8::Isolate* isolate);
- bool Load(v8::Isolate* isolate, scoped_ptr<PendingModule> pending);
+ bool Load(v8::Isolate* isolate, std::unique_ptr<PendingModule> pending);
bool RegisterModule(v8::Isolate* isolate,
const std::string& id,
v8::Local<v8::Value> module);
bool CheckDependencies(PendingModule* pending);
- bool AttemptToLoad(v8::Isolate* isolate, scoped_ptr<PendingModule> pending);
+ bool AttemptToLoad(v8::Isolate* isolate,
+ std::unique_ptr<PendingModule> pending);
v8::Local<v8::Value> GetModule(v8::Isolate* isolate, const std::string& id);
« no previous file with comments | « gin/isolate_holder.cc ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698