Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: gin/public/isolate_holder.h

Issue 1848423002: Convert //gin to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/public/context_holder.h ('k') | gin/test/v8_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index cb51c2f0844e8f6dcfcd2db0b3a40c493e670a15..7cf3d94ac898bed0ce2023d670fdb59082471e78 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -5,8 +5,9 @@
#ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_
#define GIN_PUBLIC_ISOLATE_HOLDER_H_
+#include <memory>
+
#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
#include "gin/gin_export.h"
#include "gin/public/v8_idle_task_runner.h"
#include "v8/include/v8.h"
@@ -74,7 +75,7 @@ class GIN_EXPORT IsolateHolder {
// This method returns if v8::Locker is needed to access isolate.
AccessMode access_mode() const { return access_mode_; }
- void EnableIdleTasks(scoped_ptr<V8IdleTaskRunner> idle_task_runner);
+ void EnableIdleTasks(std::unique_ptr<V8IdleTaskRunner> idle_task_runner);
// This method returns V8IsolateMemoryDumpProvider of this isolate, used for
// testing.
@@ -85,9 +86,9 @@ class GIN_EXPORT IsolateHolder {
private:
v8::Isolate* isolate_;
- scoped_ptr<PerIsolateData> isolate_data_;
- scoped_ptr<RunMicrotasksObserver> task_observer_;
- scoped_ptr<V8IsolateMemoryDumpProvider> isolate_memory_dump_provider_;
+ std::unique_ptr<PerIsolateData> isolate_data_;
+ std::unique_ptr<RunMicrotasksObserver> task_observer_;
+ std::unique_ptr<V8IsolateMemoryDumpProvider> isolate_memory_dump_provider_;
AccessMode access_mode_;
DISALLOW_COPY_AND_ASSIGN(IsolateHolder);
« no previous file with comments | « gin/public/context_holder.h ('k') | gin/test/v8_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698