Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: gin/test/v8_test.h

Issue 1848423002: Convert //gin to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/public/isolate_holder.h ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_TEST_V8_TEST_H_ 5 #ifndef GIN_TEST_V8_TEST_H_
6 #define GIN_TEST_V8_TEST_H_ 6 #define GIN_TEST_V8_TEST_H_
7 7
8 #include <memory>
9
8 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
9 #include "base/macros.h" 11 #include "base/macros.h"
10 #include "base/memory/scoped_ptr.h"
11 #include "base/message_loop/message_loop.h" 12 #include "base/message_loop/message_loop.h"
12 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
13 #include "v8/include/v8.h" 14 #include "v8/include/v8.h"
14 15
15 namespace gin { 16 namespace gin {
16 17
17 class IsolateHolder; 18 class IsolateHolder;
18 19
19 // V8Test is a simple harness for testing interactions with V8. V8Test doesn't 20 // V8Test is a simple harness for testing interactions with V8. V8Test doesn't
20 // have any dependencies on Gin's module system. 21 // have any dependencies on Gin's module system.
21 class V8Test : public testing::Test { 22 class V8Test : public testing::Test {
22 public: 23 public:
23 V8Test(); 24 V8Test();
24 ~V8Test() override; 25 ~V8Test() override;
25 26
26 void SetUp() override; 27 void SetUp() override;
27 void TearDown() override; 28 void TearDown() override;
28 29
29 protected: 30 protected:
30 base::MessageLoop message_loop_; 31 base::MessageLoop message_loop_;
31 scoped_ptr<IsolateHolder> instance_; 32 std::unique_ptr<IsolateHolder> instance_;
32 v8::Persistent<v8::Context> context_; 33 v8::Persistent<v8::Context> context_;
33 34
34 private: 35 private:
35 DISALLOW_COPY_AND_ASSIGN(V8Test); 36 DISALLOW_COPY_AND_ASSIGN(V8Test);
36 }; 37 };
37 38
38 } // namespace gin 39 } // namespace gin
39 40
40 #endif // GIN_TEST_V8_TEST_H_ 41 #endif // GIN_TEST_V8_TEST_H_
OLDNEW
« no previous file with comments | « gin/public/isolate_holder.h ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698