gin/test/v8_test.h - Issue 1848423002: Convert //gin to use std::unique_ptr - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(64)

My Issues | Starred Open | Closed | All

Unified Diff: gin/test/v8_test.h

Issue 1848423002: Convert //gin to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « gin/public/isolate_holder.h ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gin/test/v8_test.h

diff --git a/gin/test/v8_test.h b/gin/test/v8_test.h

index 3cb68d57173aaa6fc434793dfb1b4ea26cb4085d..635281b16f028603ec5918663d775f5e019f13d7 100644

--- a/gin/test/v8_test.h

+++ b/gin/test/v8_test.h

@@ -5,9 +5,10 @@

#ifndef GIN_TEST_V8_TEST_H_

#define GIN_TEST_V8_TEST_H_

+#include <memory>

+

#include "base/compiler_specific.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/message_loop/message_loop.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "v8/include/v8.h"

@@ -28,7 +29,7 @@ class V8Test : public testing::Test {

protected:

base::MessageLoop message_loop_;

- scoped_ptr<IsolateHolder> instance_;

+ std::unique_ptr<IsolateHolder> instance_;

v8::Persistent<v8::Context> context_;

private:

« no previous file with comments | « gin/public/isolate_holder.h ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698