Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1847063004: Remove "#pragma comment(lib" in components. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "#pragma comment(lib" in components. BUG=597028 Committed: https://crrev.com/400d0c0fe5962ea281abbb9a2fadaa464c0f6c13 Cr-Commit-Position: refs/heads/master@{#384595}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -13 lines) Patch
M components/crash.gypi View 2 chunks +36 lines, -0 lines 2 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/crash/content/app/breakpad_win.cc View 1 chunk +0 lines, -3 lines 2 comments Download
M components/os_crypt.gypi View 1 chunk +18 lines, -0 lines 0 comments Download
M components/os_crypt/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/os_crypt/os_crypt_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/policy/policy_common.gypi View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jam
4 years, 8 months ago (2016-04-01 14:48:49 UTC) #2
Nico
lgtm, but: https://codereview.chromium.org/1847063004/diff/1/components/crash.gypi File components/crash.gypi (right): https://codereview.chromium.org/1847063004/diff/1/components/crash.gypi#newcode301 components/crash.gypi:301: 'all_dependent_settings': { Actually, the all_dependent_blocks probably aren't ...
4 years, 8 months ago (2016-04-01 15:18:42 UTC) #3
jam
https://codereview.chromium.org/1847063004/diff/1/components/crash.gypi File components/crash.gypi (right): https://codereview.chromium.org/1847063004/diff/1/components/crash.gypi#newcode301 components/crash.gypi:301: 'all_dependent_settings': { On 2016/04/01 15:18:41, Nico wrote: > Actually, ...
4 years, 8 months ago (2016-04-01 15:32:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847063004/1
4 years, 8 months ago (2016-04-01 15:32:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 15:38:01 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 15:39:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/400d0c0fe5962ea281abbb9a2fadaa464c0f6c13
Cr-Commit-Position: refs/heads/master@{#384595}

Powered by Google App Engine
This is Rietveld 408576698