Remove "#pragma comment(lib" in components.

Remove "#pragma comment(lib" in components.

BUG=597028
Committed: https://crrev.com/400d0c0fe5962ea281abbb9a2fadaa464c0f6c13
Cr-Commit-Position: refs/heads/master@{#384595}

[jam, 2016-04-01 14:48:49]

jam@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-04-01 15:18:42]

lgtm, but:

https://codereview.chromium.org/1847063004/diff/1/components/crash.gypi
File components/crash.gypi (right):

https://codereview.chromium.org/1847063004/diff/1/components/crash.gypi#newco...
components/crash.gypi:301: 'all_dependent_settings': {
Actually, the all_dependent_blocks probably aren't really needed -- for .lib
files they'll be forwarded to the next linkable, and downstream linkables should
specify these libs themselves if they need them explicitly, right?

https://codereview.chromium.org/1847063004/diff/1/components/crash/content/ap...
File components/crash/content/app/breakpad_win.cc (left):

https://codereview.chromium.org/1847063004/diff/1/components/crash/content/ap...
components/crash/content/app/breakpad_win.cc:46: // userenv.dll is required for
GetProfileType().
(do we still need this file now that we have crashpad?)

[jam, 2016-04-01 15:32:07]

https://codereview.chromium.org/1847063004/diff/1/components/crash.gypi
File components/crash.gypi (right):

https://codereview.chromium.org/1847063004/diff/1/components/crash.gypi#newco...
components/crash.gypi:301: 'all_dependent_settings': {
On 2016/04/01 15:18:41, Nico wrote:
> Actually, the all_dependent_blocks probably aren't really needed -- for .lib
> files they'll be forwarded to the next linkable, and downstream linkables
should
> specify these libs themselves if they need them explicitly, right?

In the other places where I've been adding .libs, I've seen the pattern where
they all specify them twice in all_dependent_settings and also outside of it
like this. i.e.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_brow...

granted, I don't particularly care about gyp files at this point. i only care
about making sure that gn files are close to perfect :)

https://codereview.chromium.org/1847063004/diff/1/components/crash/content/ap...
File components/crash/content/app/breakpad_win.cc (left):

https://codereview.chromium.org/1847063004/diff/1/components/crash/content/ap...
components/crash/content/app/breakpad_win.cc:46: // userenv.dll is required for
GetProfileType().
On 2016/04/01 15:18:42, Nico wrote:
> (do we still need this file now that we have crashpad?)

temporarily:
https://code.google.com/p/chromium/codesearch#chromium/src/components/crash.g...

[jam, 2016-04-01 15:32:11]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-04-01 15:32:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847063004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847063004/1

[commit-bot: I haz the power, 2016-04-01 15:38:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-01 15:39:07]

Description was changed from

==========
Remove "#pragma comment(lib" in components.

BUG=597028
==========

to

==========
Remove "#pragma comment(lib" in components.

BUG=597028

Committed: https://crrev.com/400d0c0fe5962ea281abbb9a2fadaa464c0f6c13
Cr-Commit-Position: refs/heads/master@{#384595}
==========

[commit-bot: I haz the power, 2016-04-01 15:39:08]

Patchset 1 (id:??) landed as
https://crrev.com/400d0c0fe5962ea281abbb9a2fadaa464c0f6c13
Cr-Commit-Position: refs/heads/master@{#384595}