Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Side by Side Diff: components/crash.gypi

Issue 1847063004: Remove "#pragma comment(lib" in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/crash/core/browser 8 # GN version: //components/crash/core/browser
9 'target_name': 'crash_core_browser', 9 'target_name': 'crash_core_browser',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 ], 291 ],
292 }], 292 }],
293 ['OS=="win"', { 293 ['OS=="win"', {
294 'dependencies': [ 294 'dependencies': [
295 '../breakpad/breakpad.gyp:breakpad_handler', 295 '../breakpad/breakpad.gyp:breakpad_handler',
296 ], 296 ],
297 'include_dirs': [ 297 'include_dirs': [
298 '..', 298 '..',
299 '../breakpad/src', 299 '../breakpad/src',
300 ], 300 ],
301 'all_dependent_settings': {
Nico 2016/04/01 15:18:41 Actually, the all_dependent_blocks probably aren't
jam 2016/04/01 15:32:07 In the other places where I've been adding .libs,
302 'msvs_settings': {
303 'VCLinkerTool': {
304 'AdditionalDependencies': [
305 'userenv.lib',
306 ],
307 },
308 },
309 },
310 'msvs_settings': {
311 'VCLinkerTool': {
312 'AdditionalDependencies': [
313 'userenv.lib',
314 ],
315 },
316 },
301 }], 317 }],
302 ], 318 ],
303 }, 319 },
304 { 320 {
305 # GN version: //components/crash/content/app:test_support 321 # GN version: //components/crash/content/app:test_support
306 'target_name': 'crash_test_support', 322 'target_name': 'crash_test_support',
307 'type': 'none', 323 'type': 'none',
308 'dependencies': [ 324 'dependencies': [
309 'crash_component_lib', 325 'crash_component_lib',
310 ], 326 ],
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 '../base/base.gyp:base_win64', 382 '../base/base.gyp:base_win64',
367 '../breakpad/breakpad.gyp:breakpad_handler_win64', 383 '../breakpad/breakpad.gyp:breakpad_handler_win64',
368 '../breakpad/breakpad.gyp:breakpad_sender_win64', 384 '../breakpad/breakpad.gyp:breakpad_sender_win64',
369 '../sandbox/sandbox.gyp:sandbox_win64', 385 '../sandbox/sandbox.gyp:sandbox_win64',
370 ], 386 ],
371 'configurations': { 387 'configurations': {
372 'Common_Base': { 388 'Common_Base': {
373 'msvs_target_platform': 'x64', 389 'msvs_target_platform': 'x64',
374 }, 390 },
375 }, 391 },
392 'conditions': [
393 ['OS=="win"', {
394 'all_dependent_settings': {
395 'msvs_settings': {
396 'VCLinkerTool': {
397 'AdditionalDependencies': [
398 'userenv.lib',
399 ],
400 },
401 },
402 },
403 'msvs_settings': {
404 'VCLinkerTool': {
405 'AdditionalDependencies': [
406 'userenv.lib',
407 ],
408 },
409 },
410 }],
411 ],
376 }, 412 },
377 { 413 {
378 # GN version: //components/crash/content/tools:crash_service 414 # GN version: //components/crash/content/tools:crash_service
379 'target_name': 'breakpad_crash_service_win64', 415 'target_name': 'breakpad_crash_service_win64',
380 'type': 'static_library', 416 'type': 'static_library',
381 'dependencies': [ 417 'dependencies': [
382 '../base/base.gyp:base_win64', 418 '../base/base.gyp:base_win64',
383 '../breakpad/breakpad.gyp:breakpad_handler_win64', 419 '../breakpad/breakpad.gyp:breakpad_handler_win64',
384 '../breakpad/breakpad.gyp:breakpad_sender_win64', 420 '../breakpad/breakpad.gyp:breakpad_sender_win64',
385 ], 421 ],
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 ], 481 ],
446 }], 482 }],
447 ], 483 ],
448 }, 484 },
449 ], 485 ],
450 }], 486 }],
451 ], 487 ],
452 }], 488 }],
453 ], 489 ],
454 } 490 }
OLDNEW
« no previous file with comments | « no previous file | components/crash/content/app/BUILD.gn » ('j') | components/crash/content/app/breakpad_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698