Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: components/crash.gypi

Issue 1847063004: Remove "#pragma comment(lib" in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/crash/content/app/BUILD.gn » ('j') | components/crash/content/app/breakpad_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash.gypi
diff --git a/components/crash.gypi b/components/crash.gypi
index ddf0c1559ee257484885b325cdf50629bfaa9822..08160b3ade4757ac758aca6793cce81b952ddbe4 100644
--- a/components/crash.gypi
+++ b/components/crash.gypi
@@ -298,6 +298,22 @@
'..',
'../breakpad/src',
],
+ 'all_dependent_settings': {
Nico 2016/04/01 15:18:41 Actually, the all_dependent_blocks probably aren't
jam 2016/04/01 15:32:07 In the other places where I've been adding .libs,
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'AdditionalDependencies': [
+ 'userenv.lib',
+ ],
+ },
+ },
+ },
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'AdditionalDependencies': [
+ 'userenv.lib',
+ ],
+ },
+ },
}],
],
},
@@ -373,6 +389,26 @@
'msvs_target_platform': 'x64',
},
},
+ 'conditions': [
+ ['OS=="win"', {
+ 'all_dependent_settings': {
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'AdditionalDependencies': [
+ 'userenv.lib',
+ ],
+ },
+ },
+ },
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'AdditionalDependencies': [
+ 'userenv.lib',
+ ],
+ },
+ },
+ }],
+ ],
},
{
# GN version: //components/crash/content/tools:crash_service
« no previous file with comments | « no previous file | components/crash/content/app/BUILD.gn » ('j') | components/crash/content/app/breakpad_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698