components/crash/content/app/breakpad_win.cc - Issue 1847063004: Remove "#pragma comment(lib" in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/breakpad_win.cc

Issue 1847063004: Remove "#pragma comment(lib" in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/crash/content/app/breakpad_win.cc

diff --git a/components/crash/content/app/breakpad_win.cc b/components/crash/content/app/breakpad_win.cc

index 9cb1c3b0b0c1854066122d90604d7fab741f82b0..760bf489f559200d76b763572906a13f8d6b346a 100644

--- a/components/crash/content/app/breakpad_win.cc

+++ b/components/crash/content/app/breakpad_win.cc

@@ -43,9 +43,6 @@

#include "sandbox/win/src/nt_internals.h"

#include "sandbox/win/src/sidestep/preamble_patcher.h"

-// userenv.dll is required for GetProfileType().

Nico 2016/04/01 15:18:42 (do we still need this file now that we have crash

jam 2016/04/01 15:32:07 temporarily: https://code.google.com/p/chromium/co

-#pragma comment(lib, "userenv.lib")

#pragma intrinsic(_AddressOfReturnAddress)

#pragma intrinsic(_ReturnAddress)