Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Side by Side Diff: components/crash/content/app/breakpad_win.cc

Issue 1847063004: Remove "#pragma comment(lib" in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/crash/content/app/breakpad_win.h" 5 #include "components/crash/content/app/breakpad_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 #include <tchar.h> 10 #include <tchar.h>
(...skipping 25 matching lines...) Expand all
36 #include "breakpad/src/client/windows/common/ipc_protocol.h" 36 #include "breakpad/src/client/windows/common/ipc_protocol.h"
37 #include "breakpad/src/client/windows/handler/exception_handler.h" 37 #include "breakpad/src/client/windows/handler/exception_handler.h"
38 #include "components/crash/content/app/crash_keys_win.h" 38 #include "components/crash/content/app/crash_keys_win.h"
39 #include "components/crash/content/app/crash_reporter_client.h" 39 #include "components/crash/content/app/crash_reporter_client.h"
40 #include "components/crash/content/app/hard_error_handler_win.h" 40 #include "components/crash/content/app/hard_error_handler_win.h"
41 #include "components/crash/core/common/crash_keys.h" 41 #include "components/crash/core/common/crash_keys.h"
42 #include "content/public/common/result_codes.h" 42 #include "content/public/common/result_codes.h"
43 #include "sandbox/win/src/nt_internals.h" 43 #include "sandbox/win/src/nt_internals.h"
44 #include "sandbox/win/src/sidestep/preamble_patcher.h" 44 #include "sandbox/win/src/sidestep/preamble_patcher.h"
45 45
46 // userenv.dll is required for GetProfileType().
Nico 2016/04/01 15:18:42 (do we still need this file now that we have crash
jam 2016/04/01 15:32:07 temporarily: https://code.google.com/p/chromium/co
47 #pragma comment(lib, "userenv.lib")
48
49 #pragma intrinsic(_AddressOfReturnAddress) 46 #pragma intrinsic(_AddressOfReturnAddress)
50 #pragma intrinsic(_ReturnAddress) 47 #pragma intrinsic(_ReturnAddress)
51 48
52 #ifdef _WIN64 49 #ifdef _WIN64
53 // See http://msdn.microsoft.com/en-us/library/ddssxxy8.aspx 50 // See http://msdn.microsoft.com/en-us/library/ddssxxy8.aspx
54 typedef struct _UNWIND_INFO { 51 typedef struct _UNWIND_INFO {
55 unsigned char Version : 3; 52 unsigned char Version : 3;
56 unsigned char Flags : 5; 53 unsigned char Flags : 5;
57 unsigned char SizeOfProlog; 54 unsigned char SizeOfProlog;
58 unsigned char CountOfCodes; 55 unsigned char CountOfCodes;
(...skipping 683 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 extern "C" void __declspec(dllexport) __cdecl 739 extern "C" void __declspec(dllexport) __cdecl
743 UnregisterNonABICompliantCodeRange(void* start) { 740 UnregisterNonABICompliantCodeRange(void* start) {
744 ExceptionHandlerRecord* record = 741 ExceptionHandlerRecord* record =
745 reinterpret_cast<ExceptionHandlerRecord*>(start); 742 reinterpret_cast<ExceptionHandlerRecord*>(start);
746 743
747 CHECK(RtlDeleteFunctionTable(&record->runtime_function)); 744 CHECK(RtlDeleteFunctionTable(&record->runtime_function));
748 } 745 }
749 #endif 746 #endif
750 747
751 } // namespace breakpad 748 } // namespace breakpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698