Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1845543002: Rename Heap to ThreadHeap (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
CC:
chromium-reviews, shans, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, Mads Ager (chromium), blink-reviews-css, blink-reviews-html_chromium.org, ajuma+watch-canvas_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, nessy, rjwright, blink-reviews-style_chromium.org, sof, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, dcheng, darktears, jsbell+idb_chromium.org, vcarbune.chromium, philipj_slow, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, gasubic, pfeldman+blink_chromium.org, f(malita), pfeldman, cmumford, oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Heap to ThreadHeap BUG=591606 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/191c640cc25f76c0c0f8a0b448de33cd059f4a8e Cr-Commit-Position: refs/heads/master@{#387233} Committed: https://crrev.com/011b8046a07ac2cedde530a05f81e8fb41f80c62 Cr-Commit-Position: refs/heads/master@{#387307}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : changed trace event to BlinkGCMarking #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : rebased #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -349 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ElementData.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ElementData.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 2 3 4 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElementRareData.cpp View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js View 1 2 3 4 5 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/LifecycleContextTest.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 2 3 4 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 2 3 4 5 6 7 8 9 28 chunks +73 lines, -80 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 2 3 4 5 6 7 8 18 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 3 4 38 chunks +75 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 3 4 5 6 7 8 23 chunks +38 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebHeap.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/oilpan_gc_times.py View 1 2 3 4 5 7 8 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/oilpan_gc_times_unittest.py View 1 2 3 4 5 7 8 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 75 (41 generated)
keishi
crbug.com/1842803003 Introduce ProcessHeap crbug.com/1840103004 Introduce ThreadHeapStats crbug.com/1845543002 Rename Heap to ThreadHeap <- this
4 years, 8 months ago (2016-03-30 03:59:41 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-03-30 04:30:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/40001
4 years, 8 months ago (2016-04-01 02:43:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/163242)
4 years, 8 months ago (2016-04-01 02:54:59 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/60001
4 years, 8 months ago (2016-04-01 03:41:49 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/46614)
4 years, 8 months ago (2016-04-01 05:20:17 UTC) #13
keishi
+peria Could you review tools/perf/measurements/oilpan_gc_times*.py? +caseq Could you review TimelineModel.js? Thanks!
4 years, 8 months ago (2016-04-11 08:47:58 UTC) #15
peria
lgtm oilpan_gc_times*.py LGTM
4 years, 8 months ago (2016-04-11 08:55:52 UTC) #16
caseq
On 2016/04/11 08:47:58, keishi wrote: > +caseq Could you review TimelineModel.js? > Can we just ...
4 years, 8 months ago (2016-04-11 13:31:25 UTC) #17
keishi
On 2016/04/11 13:31:25, caseq wrote: > On 2016/04/11 08:47:58, keishi wrote: > > +caseq Could ...
4 years, 8 months ago (2016-04-11 16:31:01 UTC) #18
caseq
On 2016/04/11 16:31:01, keishi wrote: > On 2016/04/11 13:31:25, caseq wrote: > > On 2016/04/11 ...
4 years, 8 months ago (2016-04-11 16:33:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/100001
4 years, 8 months ago (2016-04-12 01:20:35 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/152941) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-12 01:48:39 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/120001
4 years, 8 months ago (2016-04-12 02:43:02 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/49183) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-12 03:04:52 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/140001
4 years, 8 months ago (2016-04-12 04:17:10 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/129)
4 years, 8 months ago (2016-04-12 05:23:54 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/160001
4 years, 8 months ago (2016-04-13 06:02:45 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/210310)
4 years, 8 months ago (2016-04-13 07:15:20 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/180001
4 years, 8 months ago (2016-04-13 07:41:45 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/132)
4 years, 8 months ago (2016-04-13 08:55:25 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/200001
4 years, 8 months ago (2016-04-13 09:28:12 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/49675)
4 years, 8 months ago (2016-04-13 09:40:25 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/220001
4 years, 8 months ago (2016-04-13 11:09:14 UTC) #52
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/134)
4 years, 8 months ago (2016-04-13 12:17:27 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/220001
4 years, 8 months ago (2016-04-13 13:36:21 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/136)
4 years, 8 months ago (2016-04-13 15:00:04 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/240001
4 years, 8 months ago (2016-04-14 02:11:43 UTC) #62
commit-bot: I haz the power
Committed patchset #13 (id:240001)
4 years, 8 months ago (2016-04-14 04:04:25 UTC) #64
commit-bot: I haz the power
Patchset 13 (id:??) landed as https://crrev.com/191c640cc25f76c0c0f8a0b448de33cd059f4a8e Cr-Commit-Position: refs/heads/master@{#387233}
4 years, 8 months ago (2016-04-14 04:05:34 UTC) #66
keishi
A revert of this CL (patchset #13 id:240001) has been created in https://codereview.chromium.org/1884083002/ by keishi@chromium.org. ...
4 years, 8 months ago (2016-04-14 07:11:20 UTC) #67
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845543002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845543002/260001
4 years, 8 months ago (2016-04-14 12:36:54 UTC) #71
commit-bot: I haz the power
Committed patchset #14 (id:260001)
4 years, 8 months ago (2016-04-14 14:21:53 UTC) #73
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 14:22:58 UTC) #75
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/011b8046a07ac2cedde530a05f81e8fb41f80c62
Cr-Commit-Position: refs/heads/master@{#387307}

Powered by Google App Engine
This is Rietveld 408576698