third_party/WebKit/Source/platform/LifecycleContextTest.cpp - Issue 1845543002: Rename Heap to ThreadHeap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LifecycleContextTest.cpp

Issue 1845543002: Rename Heap to ThreadHeap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/LifecycleContextTest.cpp

diff --git a/third_party/WebKit/Source/platform/LifecycleContextTest.cpp b/third_party/WebKit/Source/platform/LifecycleContextTest.cpp

index 7dcbd72cb7c3972f36e107b23aebf3cf84484d1f..8835ab96d485d5ec37c05e12f7c71b17a5392a27 100644

--- a/third_party/WebKit/Source/platform/LifecycleContextTest.cpp

+++ b/third_party/WebKit/Source/platform/LifecycleContextTest.cpp

@@ -102,7 +102,7 @@ TEST(LifecycleContextTest, shouldObserveContextDestroyed)

EXPECT_FALSE(observer->contextDestroyedCalled());

context->notifyContextDestroyed();

context = nullptr;

- Heap::collectAllGarbage();

+ ThreadHeap::collectAllGarbage();

EXPECT_EQ(observer->lifecycleContext(), static_cast<DummyContext*>(0));

EXPECT_TRUE(observer->contextDestroyedCalled());

}

@@ -114,7 +114,7 @@ TEST(LifecycleContextTest, shouldNotObserveContextDestroyedIfUnobserve)

observer->unobserve();

context->notifyContextDestroyed();

context = nullptr;

- Heap::collectAllGarbage();

+ ThreadHeap::collectAllGarbage();

EXPECT_EQ(observer->lifecycleContext(), static_cast<DummyContext*>(0));

EXPECT_FALSE(observer->contextDestroyedCalled());

}

@@ -136,7 +136,7 @@ TEST(LifecycleContextTest, observerRemovedDuringNotifyDestroyed)

context->notifyContextDestroyed();

EXPECT_EQ(observer->innerObserver(), nullptr);

context = nullptr;

- Heap::collectAllGarbage();

+ ThreadHeap::collectAllGarbage();

EXPECT_EQ(observer->lifecycleContext(), static_cast<DummyContext*>(0));

EXPECT_TRUE(observer->contextDestroyedCalled());

}