Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1838523004: Initialize debugger together with isolate. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, serviceworker-reviews, tzik, horo+watch_chromium.org, kinuko+serviceworker, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, michaeln, apavlov+blink_chromium.org, nhiroki, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize debugger together with isolate. This will enable following improvements: - keep track of contexts in debugger, remove V8DebuggerClient::contextsToReport; - move console object to v8_inspector; - instantiate agents in debugger; - removed withInspector from workerGlobalScope. We should also simplify contextCreated/contextDestroyed notifications by moving them to ThreadDebugger, but this needs additional investigation. BUG=580337 Committed: https://crrev.com/1d37785ee530b5f8325238101895a86a4b0c85e8 Cr-Commit-Position: refs/heads/master@{#383618}

Patch Set 1 #

Patch Set 2 : removed unnecessary assert hitting in unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -98 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 3 chunks +20 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 3 chunks +6 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 8 chunks +27 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 3 chunks +17 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-03-26 00:25:58 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-03-28 17:51:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838523004/1
4 years, 8 months ago (2016-03-28 18:09:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/135460)
4 years, 8 months ago (2016-03-28 18:28:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838523004/20001
4 years, 8 months ago (2016-03-28 20:25:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-28 23:59:16 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 00:00:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d37785ee530b5f8325238101895a86a4b0c85e8
Cr-Commit-Position: refs/heads/master@{#383618}

Powered by Google App Engine
This is Rietveld 408576698