Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h

Issue 1838523004: Initialize debugger together with isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unnecessary assert hitting in unit tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
index 05ad31187136d30f4077cebafa588fbcce8dea59..09405ec43629c487898d58b35b80c3fae00a577e 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
@@ -14,8 +14,9 @@ namespace blink {
class V8ContextInfo {
public:
- V8ContextInfo(v8::Local<v8::Context> context, bool isDefault, const String16& origin, const String16& humanReadableName, const String16& frameId)
+ V8ContextInfo(v8::Local<v8::Context> context, int contextGroupId, bool isDefault, const String16& origin, const String16& humanReadableName, const String16& frameId)
: context(context)
+ , contextGroupId(contextGroupId)
, isDefault(isDefault)
, origin(origin)
, humanReadableName(humanReadableName)
@@ -24,6 +25,10 @@ public:
}
v8::Local<v8::Context> context;
+ // Each v8::Context is a part of a group. The group id is used to find appropriate
+ // V8DebuggerAgent to notify about events in the context.
+ // |contextGroupId| must be non-0.
+ int contextGroupId;
bool isDefault;
const String16 origin;
const String16 humanReadableName;

Powered by Google App Engine
This is Rietveld 408576698