third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h - Issue 1838523004: Initialize debugger together with isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Issue 1838523004: Initialize debugger together with isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unnecessary assert hitting in unit tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

index 5152f559f3ac953801e9aa368ca9fdeae8241496..299eee071bd8c45ad9d02bb7454645e7e432ab57 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

@@ -35,13 +35,9 @@ public:

static PassOwnPtr<V8Debugger> create(v8::Isolate*, V8DebuggerClient*);

virtual ~V8Debugger() { }

- // Each v8::Context is a part of a group. The group id is used to find approapriate

- // V8DebuggerAgent to notify about events in the context.

- // |contextGroupId| must be non-0.

- static void setContextDebugData(v8::Local<v8::Context>, const String16& type, int contextGroupId);

+ // TODO(dgozman): make this non-static?

static int contextId(v8::Local<v8::Context>);

- // Context should have been already marked with |setContextDebugData| call.

virtual void contextCreated(const V8ContextInfo&) = 0;

virtual void contextDestroyed(v8::Local<v8::Context>) = 0;

virtual void resetContextGroup(int contextGroupId) = 0;