Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1838523004: Initialize debugger together with isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unnecessary assert hitting in unit tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 6ed085e04cb4f01be613b013a9fea3753e86bd46..5eae3a1c4f4025ee2f9f9d7e2c5003b31f5941ae 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -35,7 +35,6 @@
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/Settings.h"
-#include "core/inspector/IdentifiersFactory.h"
#include "core/inspector/InspectedFrames.h"
#include "core/inspector/InspectorAnimationAgent.h"
#include "core/inspector/InspectorApplicationCacheAgent.h"
@@ -113,9 +112,7 @@ public:
return;
OwnPtr<ClientMessageLoopAdapter> instance = adoptPtr(new ClientMessageLoopAdapter(adoptPtr(client->createClientMessageLoop())));
s_instance = instance.get();
- v8::Isolate* isolate = V8PerIsolateData::mainThreadIsolate();
- V8PerIsolateData* data = V8PerIsolateData::from(isolate);
- data->setThreadDebugger(MainThreadDebugger::create(instance.release(), isolate));
+ MainThreadDebugger::instance()->setClientMessageLoop(instance.release());
}
static void webViewImplClosed(WebViewImpl* view)
@@ -327,10 +324,6 @@ WebDevToolsAgentImpl::WebDevToolsAgentImpl(
ASSERT(isMainThread());
ASSERT(m_webLocalFrameImpl->frame());
- long processId = Platform::current()->getUniqueIdForProcess();
- ASSERT(processId > 0);
- IdentifiersFactory::setProcessId(processId);
-
ClientMessageLoopAdapter::ensureMainThreadDebuggerCreated(m_client);
MainThreadDebugger* mainThreadDebugger = MainThreadDebugger::instance();
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698