Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Issue 1838523004: Initialize debugger together with isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unnecessary assert hitting in unit tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8Debugger_h 5 #ifndef V8Debugger_h
6 #define V8Debugger_h 6 #define V8Debugger_h
7 7
8 #include "platform/PlatformExport.h" 8 #include "platform/PlatformExport.h"
9 #include "platform/inspector_protocol/Frontend.h" 9 #include "platform/inspector_protocol/Frontend.h"
10 #include "wtf/PassOwnPtr.h" 10 #include "wtf/PassOwnPtr.h"
(...skipping 17 matching lines...) Expand all
28 public: 28 public:
29 virtual void setInspectorState(protocol::DictionaryValue*) = 0; 29 virtual void setInspectorState(protocol::DictionaryValue*) = 0;
30 virtual void setFrontend(T*) = 0; 30 virtual void setFrontend(T*) = 0;
31 virtual void clearFrontend() = 0; 31 virtual void clearFrontend() = 0;
32 virtual void restore() = 0; 32 virtual void restore() = 0;
33 }; 33 };
34 34
35 static PassOwnPtr<V8Debugger> create(v8::Isolate*, V8DebuggerClient*); 35 static PassOwnPtr<V8Debugger> create(v8::Isolate*, V8DebuggerClient*);
36 virtual ~V8Debugger() { } 36 virtual ~V8Debugger() { }
37 37
38 // Each v8::Context is a part of a group. The group id is used to find appro apriate 38 // TODO(dgozman): make this non-static?
39 // V8DebuggerAgent to notify about events in the context.
40 // |contextGroupId| must be non-0.
41 static void setContextDebugData(v8::Local<v8::Context>, const String16& type , int contextGroupId);
42 static int contextId(v8::Local<v8::Context>); 39 static int contextId(v8::Local<v8::Context>);
43 40
44 // Context should have been already marked with |setContextDebugData| call.
45 virtual void contextCreated(const V8ContextInfo&) = 0; 41 virtual void contextCreated(const V8ContextInfo&) = 0;
46 virtual void contextDestroyed(v8::Local<v8::Context>) = 0; 42 virtual void contextDestroyed(v8::Local<v8::Context>) = 0;
47 virtual void resetContextGroup(int contextGroupId) = 0; 43 virtual void resetContextGroup(int contextGroupId) = 0;
48 44
49 static v8::Local<v8::Symbol> scopeExtensionSymbol(v8::Isolate*); 45 static v8::Local<v8::Symbol> scopeExtensionSymbol(v8::Isolate*);
50 static bool isCommandLineAPIMethod(const String16& name); 46 static bool isCommandLineAPIMethod(const String16& name);
51 static bool isCommandLineAPIGetter(const String16& name); 47 static bool isCommandLineAPIGetter(const String16& name);
52 48
53 virtual PassOwnPtr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>, size_t maxStackSize) = 0; 49 virtual PassOwnPtr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>, size_t maxStackSize) = 0;
54 virtual PassOwnPtr<V8StackTrace> captureStackTrace(size_t maxStackSize) = 0; 50 virtual PassOwnPtr<V8StackTrace> captureStackTrace(size_t maxStackSize) = 0;
55 }; 51 };
56 52
57 } // namespace blink 53 } // namespace blink
58 54
59 55
60 #endif // V8Debugger_h 56 #endif // V8Debugger_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698