Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1834733002: Revert of [Interpreter] Adds support to fetch return value on break at return. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com, oth, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Adds support to fetch return value on break at return. (patchset #9 id:160001 of https://codereview.chromium.org/1818873003/ ) Reason for revert: [Sheriff] Seems to break nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/6019 Original issue's description: > [Interpreter] Adds support to fetch return value on break at return. > > Debugger fetches the return value of a function when we break at return. > Interpreter holds the return value in accumulator. This is not stored in a > specified location on stack and hence it is not possible to look it up from > stack similar to full-codegen or optimized frames. This cl adds support to > store the value of accumulator on debug breaks. The value of accumulator is > passed to the runtime function and is then stored in thread local data. > > Also changes full-codegen implementation to match that of ignition. > The return value from full-codegen is also stored in thread local data. > The return value is fetched directly thread local data instead of > finding it by iterating over frames. > > BUG=v8:4280, v8:4690 > LOG=N > > Committed: https://crrev.com/fb65527b75754bcf3b173f16f5d0b04a1c6d9b99 > Cr-Commit-Position: refs/heads/master@{#35060} TBR=rmcilroy@chromium.org,yangguo@chromium.org,weiliang.lin@intel.com,balazs.kilvady@imgtec.com,jyan@ca.ibm.com,mythria@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:4690 Committed: https://crrev.com/25d2b2477180ce29467b16408e25a5752592944b Cr-Commit-Position: refs/heads/master@{#35065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -192 lines) Patch
M src/debug/arm/debug-arm.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M src/debug/arm64/debug-arm64.cc View 2 chunks +7 lines, -14 lines 0 comments Download
M src/debug/debug.h View 4 chunks +2 lines, -12 lines 0 comments Download
M src/debug/debug.cc View 6 chunks +24 lines, -10 lines 0 comments Download
M src/debug/ia32/debug-ia32.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M src/debug/mips/debug-mips.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M src/debug/mips64/debug-mips64.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M src/debug/ppc/debug-ppc.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M src/debug/s390/debug-s390.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M src/debug/x64/debug-x64.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M src/debug/x87/debug-x87.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 3 chunks +29 lines, -35 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [Interpreter] Adds support to fetch return value on break at return.
4 years, 9 months ago (2016-03-24 18:17:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834733002/1
4 years, 9 months ago (2016-03-24 18:17:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 18:17:47 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 18:18:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25d2b2477180ce29467b16408e25a5752592944b
Cr-Commit-Position: refs/heads/master@{#35065}

Powered by Google App Engine
This is Rietveld 408576698