Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: src/debug/x64/debug-x64.cc

Issue 1834733002: Revert of [Interpreter] Adds support to fetch return value on break at return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/s390/debug-s390.cc ('k') | src/debug/x87/debug-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/assembler.h" 7 #include "src/assembler.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 10
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 // Enter an internal frame. 62 // Enter an internal frame.
63 { 63 {
64 FrameScope scope(masm, StackFrame::INTERNAL); 64 FrameScope scope(masm, StackFrame::INTERNAL);
65 65
66 // Load padding words on stack. 66 // Load padding words on stack.
67 for (int i = 0; i < LiveEdit::kFramePaddingInitialSize; i++) { 67 for (int i = 0; i < LiveEdit::kFramePaddingInitialSize; i++) {
68 __ Push(Smi::FromInt(LiveEdit::kFramePaddingValue)); 68 __ Push(Smi::FromInt(LiveEdit::kFramePaddingValue));
69 } 69 }
70 __ Push(Smi::FromInt(LiveEdit::kFramePaddingInitialSize)); 70 __ Push(Smi::FromInt(LiveEdit::kFramePaddingInitialSize));
71 71
72 // Push arguments for DebugBreak call. 72 if (mode == SAVE_RESULT_REGISTER) __ Push(rax);
73 if (mode == SAVE_RESULT_REGISTER) { 73
74 // Break on return. 74 __ Set(rax, 0); // No arguments (argc == 0).
75 __ Push(rax);
76 } else {
77 // Non-return breaks.
78 __ Push(masm->isolate()->factory()->the_hole_value());
79 }
80 __ Set(rax, 1);
81 __ Move(rbx, ExternalReference(Runtime::FunctionForId(Runtime::kDebugBreak), 75 __ Move(rbx, ExternalReference(Runtime::FunctionForId(Runtime::kDebugBreak),
82 masm->isolate())); 76 masm->isolate()));
83 77
84 CEntryStub ceb(masm->isolate(), 1); 78 CEntryStub ceb(masm->isolate(), 1);
85 __ CallStub(&ceb); 79 __ CallStub(&ceb);
86 80
87 if (FLAG_debug_code) { 81 if (FLAG_debug_code) {
88 for (int i = 0; i < kNumJSCallerSaved; ++i) { 82 for (int i = 0; i < kNumJSCallerSaved; ++i) {
89 Register reg = {JSCallerSavedCode(i)}; 83 Register reg = {JSCallerSavedCode(i)};
90 // Do not clobber rax if SAVE_RESULT_REGISTER is set. It will 84 __ Set(reg, kDebugZapValue);
91 // contain return value of the function.
92 if (!(reg.is(rax) && SAVE_RESULT_REGISTER)) {
93 __ Set(reg, kDebugZapValue);
94 }
95 } 85 }
96 } 86 }
97 87
88 if (mode == SAVE_RESULT_REGISTER) __ Pop(rax);
89
98 // Read current padding counter and skip corresponding number of words. 90 // Read current padding counter and skip corresponding number of words.
99 __ Pop(kScratchRegister); 91 __ Pop(kScratchRegister);
100 __ SmiToInteger32(kScratchRegister, kScratchRegister); 92 __ SmiToInteger32(kScratchRegister, kScratchRegister);
101 __ leap(rsp, Operand(rsp, kScratchRegister, times_pointer_size, 0)); 93 __ leap(rsp, Operand(rsp, kScratchRegister, times_pointer_size, 0));
102 94
103 // Get rid of the internal frame. 95 // Get rid of the internal frame.
104 } 96 }
105 97
106 // This call did not replace a call , so there will be an unwanted 98 // This call did not replace a call , so there will be an unwanted
107 // return address left on the stack. Here we get rid of that. 99 // return address left on the stack. Here we get rid of that.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 } 138 }
147 139
148 const bool LiveEdit::kFrameDropperSupported = true; 140 const bool LiveEdit::kFrameDropperSupported = true;
149 141
150 #undef __ 142 #undef __
151 143
152 } // namespace internal 144 } // namespace internal
153 } // namespace v8 145 } // namespace v8
154 146
155 #endif // V8_TARGET_ARCH_X64 147 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/debug/s390/debug-s390.cc ('k') | src/debug/x87/debug-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698