Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: src/debug/x87/debug-x87.cc

Issue 1834733002: Revert of [Interpreter] Adds support to fetch return value on break at return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/x64/debug-x64.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/x87/frames-x87.h" 9 #include "src/x87/frames-x87.h"
10 10
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 // Enter an internal frame. 61 // Enter an internal frame.
62 { 62 {
63 FrameScope scope(masm, StackFrame::INTERNAL); 63 FrameScope scope(masm, StackFrame::INTERNAL);
64 64
65 // Load padding words on stack. 65 // Load padding words on stack.
66 for (int i = 0; i < LiveEdit::kFramePaddingInitialSize; i++) { 66 for (int i = 0; i < LiveEdit::kFramePaddingInitialSize; i++) {
67 __ push(Immediate(Smi::FromInt(LiveEdit::kFramePaddingValue))); 67 __ push(Immediate(Smi::FromInt(LiveEdit::kFramePaddingValue)));
68 } 68 }
69 __ push(Immediate(Smi::FromInt(LiveEdit::kFramePaddingInitialSize))); 69 __ push(Immediate(Smi::FromInt(LiveEdit::kFramePaddingInitialSize)));
70 70
71 // Push arguments for DebugBreak call. 71 if (mode == SAVE_RESULT_REGISTER) __ push(eax);
72 if (mode == SAVE_RESULT_REGISTER) { 72
73 // Break on return. 73 __ Move(eax, Immediate(0)); // No arguments.
74 __ push(eax);
75 } else {
76 // Non-return breaks.
77 __ Push(masm->isolate()->factory()->the_hole_value());
78 }
79 __ Move(eax, Immediate(1));
80 __ mov(ebx, 74 __ mov(ebx,
81 Immediate(ExternalReference( 75 Immediate(ExternalReference(
82 Runtime::FunctionForId(Runtime::kDebugBreak), masm->isolate()))); 76 Runtime::FunctionForId(Runtime::kDebugBreak), masm->isolate())));
83 77
84 CEntryStub ceb(masm->isolate(), 1); 78 CEntryStub ceb(masm->isolate(), 1);
85 __ CallStub(&ceb); 79 __ CallStub(&ceb);
86 80
87 if (FLAG_debug_code) { 81 if (FLAG_debug_code) {
88 for (int i = 0; i < kNumJSCallerSaved; ++i) { 82 for (int i = 0; i < kNumJSCallerSaved; ++i) {
89 Register reg = {JSCallerSavedCode(i)}; 83 Register reg = {JSCallerSavedCode(i)};
90 // Do not clobber eax if SAVE_RESULT_REGISTER is set. It will 84 __ Move(reg, Immediate(kDebugZapValue));
91 // contain return value of the function.
92 if (!(reg.is(eax) && SAVE_RESULT_REGISTER)) {
93 __ Move(reg, Immediate(kDebugZapValue));
94 }
95 } 85 }
96 } 86 }
97 87
88 if (mode == SAVE_RESULT_REGISTER) __ pop(eax);
89
98 __ pop(ebx); 90 __ pop(ebx);
99 // We divide stored value by 2 (untagging) and multiply it by word's size. 91 // We divide stored value by 2 (untagging) and multiply it by word's size.
100 STATIC_ASSERT(kSmiTagSize == 1 && kSmiShiftSize == 0); 92 STATIC_ASSERT(kSmiTagSize == 1 && kSmiShiftSize == 0);
101 __ lea(esp, Operand(esp, ebx, times_half_pointer_size, 0)); 93 __ lea(esp, Operand(esp, ebx, times_half_pointer_size, 0));
102 94
103 // Get rid of the internal frame. 95 // Get rid of the internal frame.
104 } 96 }
105 97
106 // This call did not replace a call , so there will be an unwanted 98 // This call did not replace a call , so there will be an unwanted
107 // return address left on the stack. Here we get rid of that. 99 // return address left on the stack. Here we get rid of that.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 138
147 139
148 const bool LiveEdit::kFrameDropperSupported = true; 140 const bool LiveEdit::kFrameDropperSupported = true;
149 141
150 #undef __ 142 #undef __
151 143
152 } // namespace internal 144 } // namespace internal
153 } // namespace v8 145 } // namespace v8
154 146
155 #endif // V8_TARGET_ARCH_X87 147 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/debug/x64/debug-x64.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698