Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: src/debug/x87/debug-x87.cc

Issue 1834733002: Revert of [Interpreter] Adds support to fetch return value on break at return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/x64/debug-x64.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/x87/debug-x87.cc
diff --git a/src/debug/x87/debug-x87.cc b/src/debug/x87/debug-x87.cc
index b4dbfc9bb9f65562f5db3c7f854817a6c3e0ab0b..28b635b3266ac7ed8c48aaba6a94a9b678f4489e 100644
--- a/src/debug/x87/debug-x87.cc
+++ b/src/debug/x87/debug-x87.cc
@@ -68,15 +68,9 @@
}
__ push(Immediate(Smi::FromInt(LiveEdit::kFramePaddingInitialSize)));
- // Push arguments for DebugBreak call.
- if (mode == SAVE_RESULT_REGISTER) {
- // Break on return.
- __ push(eax);
- } else {
- // Non-return breaks.
- __ Push(masm->isolate()->factory()->the_hole_value());
- }
- __ Move(eax, Immediate(1));
+ if (mode == SAVE_RESULT_REGISTER) __ push(eax);
+
+ __ Move(eax, Immediate(0)); // No arguments.
__ mov(ebx,
Immediate(ExternalReference(
Runtime::FunctionForId(Runtime::kDebugBreak), masm->isolate())));
@@ -87,13 +81,11 @@
if (FLAG_debug_code) {
for (int i = 0; i < kNumJSCallerSaved; ++i) {
Register reg = {JSCallerSavedCode(i)};
- // Do not clobber eax if SAVE_RESULT_REGISTER is set. It will
- // contain return value of the function.
- if (!(reg.is(eax) && SAVE_RESULT_REGISTER)) {
- __ Move(reg, Immediate(kDebugZapValue));
- }
+ __ Move(reg, Immediate(kDebugZapValue));
}
}
+
+ if (mode == SAVE_RESULT_REGISTER) __ pop(eax);
__ pop(ebx);
// We divide stored value by 2 (untagging) and multiply it by word's size.
« no previous file with comments | « src/debug/x64/debug-x64.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698