Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: src/interpreter/interpreter.cc

Issue 1834733002: Revert of [Interpreter] Adds support to fetch return value on break at return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/x87/debug-x87.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/interpreter.h" 5 #include "src/interpreter/interpreter.h"
6 6
7 #include "src/ast/prettyprinter.h" 7 #include "src/ast/prettyprinter.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/factory.h" 10 #include "src/factory.h"
(...skipping 1465 matching lines...) Expand 10 before | Expand all | Expand 10 after
1476 // Call runtime to handle debugger statement. 1476 // Call runtime to handle debugger statement.
1477 void Interpreter::DoDebugger(InterpreterAssembler* assembler) { 1477 void Interpreter::DoDebugger(InterpreterAssembler* assembler) {
1478 Node* context = __ GetContext(); 1478 Node* context = __ GetContext();
1479 __ CallRuntime(Runtime::kHandleDebuggerStatement, context); 1479 __ CallRuntime(Runtime::kHandleDebuggerStatement, context);
1480 __ Dispatch(); 1480 __ Dispatch();
1481 } 1481 }
1482 1482
1483 // DebugBreak 1483 // DebugBreak
1484 // 1484 //
1485 // Call runtime to handle a debug break. 1485 // Call runtime to handle a debug break.
1486 #define DEBUG_BREAK(Name, ...) \ 1486 #define DEBUG_BREAK(Name, ...) \
1487 void Interpreter::Do##Name(InterpreterAssembler* assembler) { \ 1487 void Interpreter::Do##Name(InterpreterAssembler* assembler) { \
1488 Node* context = __ GetContext(); \ 1488 Node* context = __ GetContext(); \
1489 Node* accumulator = __ GetAccumulator(); \ 1489 Node* original_handler = __ CallRuntime(Runtime::kDebugBreak, context); \
1490 Node* original_handler = \ 1490 __ DispatchToBytecodeHandler(original_handler); \
1491 __ CallRuntime(Runtime::kDebugBreakOnBytecode, context, accumulator); \
1492 __ DispatchToBytecodeHandler(original_handler); \
1493 } 1491 }
1494 DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK); 1492 DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK);
1495 #undef DEBUG_BREAK 1493 #undef DEBUG_BREAK
1496 1494
1497 // ForInPrepare <cache_info_triple> 1495 // ForInPrepare <cache_info_triple>
1498 // 1496 //
1499 // Returns state for for..in loop execution based on the object in the 1497 // Returns state for for..in loop execution based on the object in the
1500 // accumulator. The result is output in registers |cache_info_triple| to 1498 // accumulator. The result is output in registers |cache_info_triple| to
1501 // |cache_info_triple + 2|, with the registers holding cache_type, cache_array, 1499 // |cache_info_triple + 2|, with the registers holding cache_type, cache_array,
1502 // and cache_length respectively. 1500 // and cache_length respectively.
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
1619 // Illegal 1617 // Illegal
1620 // 1618 //
1621 // An invalid bytecode aborting execution if dispatched. 1619 // An invalid bytecode aborting execution if dispatched.
1622 void Interpreter::DoIllegal(InterpreterAssembler* assembler) { 1620 void Interpreter::DoIllegal(InterpreterAssembler* assembler) {
1623 __ Abort(kInvalidBytecode); 1621 __ Abort(kInvalidBytecode);
1624 } 1622 }
1625 1623
1626 } // namespace interpreter 1624 } // namespace interpreter
1627 } // namespace internal 1625 } // namespace internal
1628 } // namespace v8 1626 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/x87/debug-x87.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698