Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1833053004: [Extensions] Convert APIs to use movable types [10] (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert APIs to use movable types [10] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - terminal_private.json - top_sites.json - tts.json - tts_engine.json - types.json - types_private.json - users_private.idl - wallpaper.json - wallpaper_private.json - web_navigation.json - webrtc_audio_private.idl - webrtc_desktop_capture_private.idl - webrtc_logging_private.idl - webstore.json - webstore_private.json - webstore_widget_private.idl - webview_tag.json - alarms.idl - app_current_window_internal.idl - app_runtime.idl - app_view_guest_internal.json - app_window.idl - audio.idl Also change AudioGetInfoFunction to be a SyncExtensionFunction for cleanup. BUG=595949 Committed: https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231 Cr-Commit-Position: refs/heads/master@{#383628}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -131 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/terminal_private.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/top_sites.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/tts.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/tts_engine.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/types.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/types_private.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/users_private.idl View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/wallpaper.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/wallpaper_private.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/web_navigation.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/webrtc_audio_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/webrtc_desktop_capture_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/webrtc_logging_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/webstore.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/webstore_private.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/webstore_widget_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/webview_tag.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/alarms/alarms_api.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M extensions/browser/api/audio/audio_api.h View 1 chunk +2 lines, -7 lines 0 comments Download
M extensions/browser/api/audio/audio_api.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M extensions/browser/api/audio/audio_service.h View 3 chunks +7 lines, -10 lines 0 comments Download
M extensions/browser/api/audio/audio_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/audio/audio_service_chromeos.cc View 3 chunks +33 lines, -39 lines 0 comments Download
M extensions/common/api/alarms.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/app_current_window_internal.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/app_runtime.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/app_view_guest_internal.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/app_window.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/audio.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Devlin
4 years, 9 months ago (2016-03-25 22:12:17 UTC) #4
lazyboy
lgtm nit: I'd also add a note in CL desc to say audio.getInfo is now ...
4 years, 9 months ago (2016-03-25 23:06:38 UTC) #5
Devlin
On 2016/03/25 23:06:38, lazyboy wrote: > lgtm > nit: I'd also add a note in ...
4 years, 8 months ago (2016-03-28 22:17:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833053004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833053004/40001
4 years, 8 months ago (2016-03-29 00:09:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-03-29 00:19:05 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 00:20:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231
Cr-Commit-Position: refs/heads/master@{#383628}

Powered by Google App Engine
This is Rietveld 408576698