chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc - Issue 1833053004: [Extensions] Convert APIs to use movable types [10]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

Issue 1833053004: [Extensions] Convert APIs to use movable types [10] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

index e0ce0be81e4c0ec554d584651962d0a61a1641a5..c7a4141e4793ca838045d9205710b82f3ddc0f6d 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

@@ -161,8 +161,8 @@ bool WebrtcLoggingPrivateSetMetaDataFunction::RunAsync() {

return false;

scoped_ptr<MetaDataMap> meta_data(new MetaDataMap());

- for (const linked_ptr<MetaDataEntry>& entry : params->meta_data)

- (*meta_data.get())[entry->key] = entry->value;

+ for (const MetaDataEntry& entry : params->meta_data)

+ (*meta_data.get())[entry.key] = entry.value;

BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(

&WebRtcLoggingHandlerHost::SetMetaData, webrtc_logging_handler_host,