extensions/browser/api/audio/audio_api.h - Issue 1833053004: [Extensions] Convert APIs to use movable types [10]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/audio/audio_api.h

Issue 1833053004: [Extensions] Convert APIs to use movable types [10] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc ('k') | extensions/browser/api/audio/audio_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/audio/audio_api.h

diff --git a/extensions/browser/api/audio/audio_api.h b/extensions/browser/api/audio/audio_api.h

index 29e526b194597d51f72bd03480a86a50c87135d9..e1a45347546f28e4f7516a2acdaaee1fc1381dd9 100644

--- a/extensions/browser/api/audio/audio_api.h

+++ b/extensions/browser/api/audio/audio_api.h

@@ -41,18 +41,13 @@ class AudioAPI : public BrowserContextKeyedAPI, public AudioService::Observer {

AudioService* service_;

};

-class AudioGetInfoFunction : public AsyncExtensionFunction {

+class AudioGetInfoFunction : public SyncExtensionFunction {

public:

DECLARE_EXTENSION_FUNCTION("audio.getInfo", AUDIO_GETINFO);

protected:

~AudioGetInfoFunction() override {}

- bool RunAsync() override;

- private:

- void OnGetInfoCompleted(const OutputInfo& output_info,

- const InputInfo& input_info,

- bool success);

+ bool RunSync() override;

};

class AudioSetActiveDevicesFunction : public SyncExtensionFunction {