extensions/browser/api/alarms/alarms_api.cc - Issue 1833053004: [Extensions] Convert APIs to use movable types [10]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/alarms/alarms_api.cc

Issue 1833053004: [Extensions] Convert APIs to use movable types [10] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/webview_tag.json ('k') | extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/alarms/alarms_api.cc

diff --git a/extensions/browser/api/alarms/alarms_api.cc b/extensions/browser/api/alarms/alarms_api.cc

index 7a2a8c27fea956fea0588d9d72e61ed438413b12..102bce4f8631da89641d5bc81c55d7afdcc03eb7 100644

--- a/extensions/browser/api/alarms/alarms_api.cc

+++ b/extensions/browser/api/alarms/alarms_api.cc

@@ -162,16 +162,12 @@ bool AlarmsGetAllFunction::RunAsync() {

}

void AlarmsGetAllFunction::Callback(const AlarmList* alarms) {

+ scoped_ptr<base::ListValue> alarms_value(new base::ListValue());

if (alarms) {

- std::vector<linked_ptr<alarms::Alarm>> create_arg;

- create_arg.reserve(alarms->size());

- for (size_t i = 0, size = alarms->size(); i < size; ++i) {

- create_arg.push_back((*alarms)[i].js_alarm);

- }

- results_ = alarms::GetAll::Results::Create(create_arg);

- } else {

- SetResult(new base::ListValue());

+ for (const Alarm& alarm : *alarms)

+ alarms_value->Append(alarm.js_alarm->ToValue());

}

+ SetResult(std::move(alarms_value));

SendResponse(true);

}