Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: extensions/browser/api/audio/audio_api.cc

Issue 1833053004: [Extensions] Convert APIs to use movable types [10] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/audio/audio_api.h ('k') | extensions/browser/api/audio/audio_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/audio/audio_api.cc
diff --git a/extensions/browser/api/audio/audio_api.cc b/extensions/browser/api/audio/audio_api.cc
index 947ecd6d738cdbd6a037f682c14d1ee11b8ea18d..ad1f22d85e98d0355e6afb79c5d2e146128178ff 100644
--- a/extensions/browser/api/audio/audio_api.cc
+++ b/extensions/browser/api/audio/audio_api.cc
@@ -80,23 +80,19 @@ void AudioAPI::OnDevicesChanged(const DeviceInfoList& devices) {
///////////////////////////////////////////////////////////////////////////////
-bool AudioGetInfoFunction::RunAsync() {
+bool AudioGetInfoFunction::RunSync() {
AudioService* service =
AudioAPI::GetFactoryInstance()->Get(browser_context())->GetService();
DCHECK(service);
- service->StartGetInfo(base::Bind(&AudioGetInfoFunction::OnGetInfoCompleted,
- this));
- return true;
-}
-
-void AudioGetInfoFunction::OnGetInfoCompleted(const OutputInfo& output_info,
- const InputInfo& input_info,
- bool success) {
- if (success)
- results_ = audio::GetInfo::Results::Create(output_info, input_info);
- else
+ OutputInfo output_info;
+ InputInfo input_info;
+ if (!service->GetInfo(&output_info, &input_info)) {
SetError("Error occurred when querying audio device information.");
- SendResponse(success);
+ return false;
+ }
+
+ results_ = audio::GetInfo::Results::Create(output_info, input_info);
+ return true;
}
///////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « extensions/browser/api/audio/audio_api.h ('k') | extensions/browser/api/audio/audio_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698