Move SVGTests attributes parsing to SVGGraphicsElement

Move SVGTests attributes parsing to SVGGraphicsElement

Move SVGTests attributes parsing to SVGGraphicsElement instead of doing
this in each of its subclasses. SVGGraphicsElement is now the one
subclassing SVGTests after r153166.

BUG=256618
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153459

[Stephen Chennney, 2013-07-01 13:35:05]

The Mac and Windows builds are failing for good reason. Please fix before I
review.

The isSupportedAttribute call in SVGSVGElement is apparently not behaving as you
expect. It will take some effort to fix because it's marked override but no
superclass declares it, which suggest you'll need to figure out which class
defines it and how to get the inheritance right.

[do-not-use, 2013-07-01 13:37:41]

On 2013/07/01 13:35:05, Stephen Chenney wrote:
> The Mac and Windows builds are failing for good reason. Please fix before I
> review.
> 
> The isSupportedAttribute call in SVGSVGElement is apparently not behaving as
you
> expect. It will take some effort to fix because it's marked override but no
> superclass declares it, which suggest you'll need to figure out which class
> defines it and how to get the inheritance right.

Sorry, isSupportedAttribute() should not be virtual at all. I'll fix and
reupload.

[do-not-use, 2013-07-01 13:42:17]

On 2013/07/01 13:37:41, cdumez wrote:
> On 2013/07/01 13:35:05, Stephen Chenney wrote:
> > The Mac and Windows builds are failing for good reason. Please fix before I
> > review.
> > 
> > The isSupportedAttribute call in SVGSVGElement is apparently not behaving as
> you
> > expect. It will take some effort to fix because it's marked override but no
> > superclass declares it, which suggest you'll need to figure out which class
> > defines it and how to get the inheritance right.
> 
> Sorry, isSupportedAttribute() should not be virtual at all. I'll fix and
> reupload.

This is fixed in Patch Set 2.

[do-not-use, 2013-07-02 12:21:02]

Corresponding WebKit patch:
https://bugs.webkit.org/show_bug.cgi?id=118292

[krit, 2013-07-02 19:28:30]

On 2013/07/02 12:21:02, Christophe Dumez wrote:
> Corresponding WebKit patch:
> https://bugs.webkit.org/show_bug.cgi?id=118292

It is easier of you upload the patch for review in either WebKit or Blink first
and await a review. It still needs a second review in the other project, but at
least we do not spend the same time for the second review. Thanks!

[do-not-use, 2013-07-02 19:47:30]

https://codereview.chromium.org/18328007/diff/12001/Source/core/svg/SVGSVGEle...
File Source/core/svg/SVGSVGElement.cpp (right):

https://codereview.chromium.org/18328007/diff/12001/Source/core/svg/SVGSVGEle...
Source/core/svg/SVGSVGElement.cpp:224: bool
SVGSVGElement::isSupportedAttribute(const QualifiedName& attrName)
This is actually not needed, sorry. The real issue is that svgAttributeChanged()
delegates to SVGStyledElement instead of its parent (SVGGraphicsElement) if the
attribute is not supported. I will fix svgAttributeChanged() instead.

[do-not-use, 2013-07-02 20:05:24]

On 2013/07/02 19:47:30, Christophe Dumez wrote:
>
https://codereview.chromium.org/18328007/diff/12001/Source/core/svg/SVGSVGEle...
> File Source/core/svg/SVGSVGElement.cpp (right):
> 
>
https://codereview.chromium.org/18328007/diff/12001/Source/core/svg/SVGSVGEle...
> Source/core/svg/SVGSVGElement.cpp:224: bool
> SVGSVGElement::isSupportedAttribute(const QualifiedName& attrName)
> This is actually not needed, sorry. The real issue is that
svgAttributeChanged()
> delegates to SVGStyledElement instead of its parent (SVGGraphicsElement) if
the
> attribute is not supported. I will fix svgAttributeChanged() instead.

This is fixed in Patch Set 3.

[do-not-use, 2013-07-02 20:05:43]

On 2013/07/02 20:05:24, Christophe Dumez wrote:
> On 2013/07/02 19:47:30, Christophe Dumez wrote:
> >
>
https://codereview.chromium.org/18328007/diff/12001/Source/core/svg/SVGSVGEle...
> > File Source/core/svg/SVGSVGElement.cpp (right):
> > 
> >
>
https://codereview.chromium.org/18328007/diff/12001/Source/core/svg/SVGSVGEle...
> > Source/core/svg/SVGSVGElement.cpp:224: bool
> > SVGSVGElement::isSupportedAttribute(const QualifiedName& attrName)
> > This is actually not needed, sorry. The real issue is that
> svgAttributeChanged()
> > delegates to SVGStyledElement instead of its parent (SVGGraphicsElement) if
> the
> > attribute is not supported. I will fix svgAttributeChanged() instead.
> 
> This is fixed in Patch Set 3.

I meant 4

[do-not-use, 2013-07-02 20:21:37]

On 2013/07/02 19:28:30, krit wrote:
> On 2013/07/02 12:21:02, Christophe Dumez wrote:
> > Corresponding WebKit patch:
> > https://bugs.webkit.org/show_bug.cgi?id=118292
> 
> It is easier of you upload the patch for review in either WebKit or Blink
first
> and await a review. It still needs a second review in the other project, but
at
> least we do not spend the same time for the second review. Thanks!

Sure, sorry about that. I usually do this but I overlooked that this patch had
not landed in Blink yet. I'll be more careful.

[Stephen Chennney, 2013-07-02 21:20:24]

lgtm

[commit-bot: I haz the power, 2013-07-02 21:20:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18328007/21001

[commit-bot: I haz the power, 2013-07-02 23:40:11]

Change committed as 153459