Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Source/core/svg/SVGAElement.cpp

Issue 18328007: Move SVGTests attributes parsing to SVGGraphicsElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix issue in SVGSVGElement::svgAttributeChanged() Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/svg/SVGCircleElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 // Otherwise, use the title of this element. 88 // Otherwise, use the title of this element.
89 return SVGStyledElement::title(); 89 return SVGStyledElement::title();
90 } 90 }
91 91
92 bool SVGAElement::isSupportedAttribute(const QualifiedName& attrName) 92 bool SVGAElement::isSupportedAttribute(const QualifiedName& attrName)
93 { 93 {
94 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ()); 94 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
95 if (supportedAttributes.isEmpty()) { 95 if (supportedAttributes.isEmpty()) {
96 SVGURIReference::addSupportedAttributes(supportedAttributes); 96 SVGURIReference::addSupportedAttributes(supportedAttributes);
97 SVGTests::addSupportedAttributes(supportedAttributes);
98 SVGLangSpace::addSupportedAttributes(supportedAttributes); 97 SVGLangSpace::addSupportedAttributes(supportedAttributes);
99 SVGExternalResourcesRequired::addSupportedAttributes(supportedAttributes ); 98 SVGExternalResourcesRequired::addSupportedAttributes(supportedAttributes );
100 supportedAttributes.add(SVGNames::targetAttr); 99 supportedAttributes.add(SVGNames::targetAttr);
101 } 100 }
102 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName); 101 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
103 } 102 }
104 103
105 void SVGAElement::parseAttribute(const QualifiedName& name, const AtomicString& value) 104 void SVGAElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
106 { 105 {
107 if (!isSupportedAttribute(name)) { 106 if (!isSupportedAttribute(name)) {
108 SVGGraphicsElement::parseAttribute(name, value); 107 SVGGraphicsElement::parseAttribute(name, value);
109 return; 108 return;
110 } 109 }
111 110
112 if (name == SVGNames::targetAttr) { 111 if (name == SVGNames::targetAttr) {
113 setSVGTargetBaseValue(value); 112 setSVGTargetBaseValue(value);
114 return; 113 return;
115 } 114 }
116 115
117 if (SVGURIReference::parseAttribute(name, value)) 116 if (SVGURIReference::parseAttribute(name, value))
118 return; 117 return;
119 if (SVGTests::parseAttribute(name, value))
120 return;
121 if (SVGLangSpace::parseAttribute(name, value)) 118 if (SVGLangSpace::parseAttribute(name, value))
122 return; 119 return;
123 if (SVGExternalResourcesRequired::parseAttribute(name, value)) 120 if (SVGExternalResourcesRequired::parseAttribute(name, value))
124 return; 121 return;
125 122
126 ASSERT_NOT_REACHED(); 123 ASSERT_NOT_REACHED();
127 } 124 }
128 125
129 void SVGAElement::svgAttributeChanged(const QualifiedName& attrName) 126 void SVGAElement::svgAttributeChanged(const QualifiedName& attrName)
130 { 127 {
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 // The 'a' element may contain any element that its parent may contain, exce pt itself. 234 // The 'a' element may contain any element that its parent may contain, exce pt itself.
238 if (childContext.node()->hasTagName(SVGNames::aTag)) 235 if (childContext.node()->hasTagName(SVGNames::aTag))
239 return false; 236 return false;
240 if (parentNode() && parentNode()->isSVGElement()) 237 if (parentNode() && parentNode()->isSVGElement())
241 return parentNode()->childShouldCreateRenderer(childContext); 238 return parentNode()->childShouldCreateRenderer(childContext);
242 239
243 return SVGElement::childShouldCreateRenderer(childContext); 240 return SVGElement::childShouldCreateRenderer(childContext);
244 } 241 }
245 242
246 } // namespace WebCore 243 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/svg/SVGCircleElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698