Move SVGTests attributes parsing to SVGGraphicsElement

Source/core/svg/SVGSVGElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 203 matching lines @@
 
 void SVGSVGElement::updateCurrentTranslate()
 {
     if (RenderObject* object = renderer())
         object->setNeedsLayout(true);
 
     if (parentNode() == document() && document()->renderer())
         document()->renderer()->repaint();
 }
 
+bool SVGSVGElement::isSupportedAttribute(const QualifiedName& attrName)

[do-not-use, 2013/07/02 19:47:30]

This is actually not needed, sorry. The real issue is that svgAttributeChanged()
delegates to SVGStyledElement instead of its parent (SVGGraphicsElement) if the
attribute is not supported. I will fix svgAttributeChanged() instead.

+{
+    DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
+    if (supportedAttributes.isEmpty()) {
+        SVGExternalResourcesRequired::addSupportedAttributes(supportedAttributes);
+        SVGFitToViewBox::addSupportedAttributes(supportedAttributes);
+        SVGLangSpace::addSupportedAttributes(supportedAttributes);
+        SVGZoomAndPan::addSupportedAttributes(supportedAttributes);
+        supportedAttributes.add(SVGNames::xAttr);
+        supportedAttributes.add(SVGNames::yAttr);
+        supportedAttributes.add(SVGNames::widthAttr);
+        supportedAttributes.add(SVGNames::heightAttr);
+        supportedAttributes.add(SVGNames::onzoomAttr);
+        supportedAttributes.add(HTMLNames::onabortAttr);
+        supportedAttributes.add(HTMLNames::onerrorAttr);
+        supportedAttributes.add(HTMLNames::onunloadAttr);
+        supportedAttributes.add(HTMLNames::onresizeAttr);
+        supportedAttributes.add(HTMLNames::onscrollAttr);
+    }
+    return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
+}
+
 void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
+    if (!isSupportedAttribute(name)) {
+        SVGGraphicsElement::parseAttribute(name, value);
+        return;
+    }
+
     SVGParsingError parseError = NoError;
 
     if (!nearestViewportElement()) {
         bool setListener = true;
 
         // Only handle events if we're the outermost <svg> element
         if (name == HTMLNames::onunloadAttr)
             document()->setWindowAttributeEventListener(eventNames().unloadEvent, createAttributeEventListener(document()->frame(), name, value));
         else if (name == HTMLNames::onresizeAttr)
             document()->setWindowAttributeEventListener(eventNames().resizeEvent, createAttributeEventListener(document()->frame(), name, value));
@@ skipping 13 matching lines @@
     else if (name == HTMLNames::onerrorAttr)
         document()->setWindowAttributeEventListener(eventNames().errorEvent, createAttributeEventListener(document()->frame(), name, value));
     else if (name == SVGNames::xAttr)
         setXBaseValue(SVGLength::construct(LengthModeWidth, value, parseError));
     else if (name == SVGNames::yAttr)
         setYBaseValue(SVGLength::construct(LengthModeHeight, value, parseError));
     else if (name == SVGNames::widthAttr)
         setWidthBaseValue(SVGLength::construct(LengthModeWidth, value, parseError, ForbidNegativeLengths));
     else if (name == SVGNames::heightAttr)
         setHeightBaseValue(SVGLength::construct(LengthModeHeight, value, parseError, ForbidNegativeLengths));
-    else if (SVGTests::parseAttribute(name, value)
-               || SVGLangSpace::parseAttribute(name, value)
+    else if (SVGLangSpace::parseAttribute(name, value)
                || SVGExternalResourcesRequired::parseAttribute(name, value)
                || SVGFitToViewBox::parseAttribute(this, name, value)
                || SVGZoomAndPan::parseAttribute(this, name, value)) {
     } else
         SVGGraphicsElement::parseAttribute(name, value);
 
     reportAttributeParsingError(parseError, name, value);
 }
 
 void SVGSVGElement::svgAttributeChanged(const QualifiedName& attrName)
 { 
+    if (!isSupportedAttribute(attrName)) {
+        SVGGraphicsElement::svgAttributeChanged(attrName);
+        return;
+    }
+
     bool updateRelativeLengthsOrViewBox = false;
     bool widthChanged = attrName == SVGNames::widthAttr;
     if (widthChanged
         || attrName == SVGNames::heightAttr
         || attrName == SVGNames::xAttr
         || attrName == SVGNames::yAttr) {
         updateRelativeLengthsOrViewBox = true;
         updateRelativeLengthsInformation();
 
         // At the SVG/HTML boundary (aka RenderSVGRoot), the width attribute can
         // affect the replaced size so we need to mark it for updating.
         if (widthChanged) {
             RenderObject* renderObject = renderer();
             if (renderObject && renderObject->isSVGRoot())
                 toRenderSVGRoot(renderObject)->setNeedsLayoutAndPrefWidthsRecalc();
         }
     }
 
     if (SVGFitToViewBox::isKnownAttribute(attrName)) {
         updateRelativeLengthsOrViewBox = true; 
         if (RenderObject* object = renderer())
             object->setNeedsTransformUpdate();
     }
 
     SVGElementInstance::InvalidationGuard invalidationGuard(this);
-    if (SVGTests::handleAttributeChange(this, attrName))
-        return;
 
     if (updateRelativeLengthsOrViewBox
         || SVGLangSpace::isKnownAttribute(attrName)
         || SVGExternalResourcesRequired::isKnownAttribute(attrName)
         || SVGZoomAndPan::isKnownAttribute(attrName)) {
         if (renderer())
             RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer());
         return;
     }
 
@@ skipping 462 matching lines @@
             continue;
 
         Element* element = toElement(node);
         if (element->getIdAttribute() == id)
             return element;
     }
     return 0;
 }
 
 }