Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: Source/core/svg/SVGGraphicsElement.cpp

Issue 18328007: Move SVGTests attributes parsing to SVGGraphicsElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix issue in SVGSVGElement::svgAttributeChanged() Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGGElement.cpp ('k') | Source/core/svg/SVGImageElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGGraphicsElement.cpp
diff --git a/Source/core/svg/SVGGraphicsElement.cpp b/Source/core/svg/SVGGraphicsElement.cpp
index 9838822837530c3895f45e71e6ff4aef52e4bc67..2dfd3de561b4fcd85e0f32ffef5125fd29ad5b16 100644
--- a/Source/core/svg/SVGGraphicsElement.cpp
+++ b/Source/core/svg/SVGGraphicsElement.cpp
@@ -93,8 +93,10 @@ AffineTransform* SVGGraphicsElement::supplementalTransform()
bool SVGGraphicsElement::isSupportedAttribute(const QualifiedName& attrName)
{
DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
- if (supportedAttributes.isEmpty())
+ if (supportedAttributes.isEmpty()) {
+ SVGTests::addSupportedAttributes(supportedAttributes);
supportedAttributes.add(SVGNames::transformAttr);
+ }
return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
}
@@ -111,6 +113,8 @@ void SVGGraphicsElement::parseAttribute(const QualifiedName& name, const AtomicS
detachAnimatedTransformListWrappers(newList.size());
setTransformBaseValue(newList);
return;
+ } else if (SVGTests::parseAttribute(name, value)) {
+ return;
}
ASSERT_NOT_REACHED();
@@ -125,6 +129,9 @@ void SVGGraphicsElement::svgAttributeChanged(const QualifiedName& attrName)
SVGElementInstance::InvalidationGuard invalidationGuard(this);
+ if (SVGTests::handleAttributeChange(this, attrName))
+ return;
+
RenderObject* object = renderer();
if (!object)
return;
« no previous file with comments | « Source/core/svg/SVGGElement.cpp ('k') | Source/core/svg/SVGImageElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698